From 5b08f48b2e893d6b6642cdc3a666a255102251b9 Mon Sep 17 00:00:00 2001 From: Reinaldy Rafli Date: Fri, 7 Aug 2026 15:30:59 +0700 Subject: [PATCH 1/3] fix: stop the right containers for minimize-downtime flag --- install/turn-things-off.sh | 4 ++-- install/wrap-up.sh | 15 +++++---------- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/install/turn-things-off.sh b/install/turn-things-off.sh index fc0ddf38d48..8086726a323 100644 --- a/install/turn-things-off.sh +++ b/install/turn-things-off.sh @@ -1,8 +1,8 @@ echo "${_group}Turning things off ..." if [[ -n "$MINIMIZE_DOWNTIME" ]]; then - # Stop everything but relay and nginx - $dc rm -fsv $($dc config --services | grep -v -E '^(nginx|relay)$') + # Stop everything unless databases, relay, web, and nginx + $dc down -fsv $($dc config --services | grep -v -E '^(nginx|web|relay|smtp|memcached|redis|postgres|pgbouncer|kafka|clickhouse|seaweedfs)$') else # Clean up old stuff and ensure nothing is working while we install/update if [ "$CONTAINER_ENGINE" = "podman" ]; then diff --git a/install/wrap-up.sh b/install/wrap-up.sh index 5093dd76ad1..45d748f9d8d 100644 --- a/install/wrap-up.sh +++ b/install/wrap-up.sh @@ -1,19 +1,14 @@ if [[ "$MINIMIZE_DOWNTIME" ]]; then echo "${_group}Waiting for Sentry to start ..." - # Start the whole setup, except nginx and relay. - start_service_and_wait_ready --remove-orphans $($dc config --services | grep -v -E '^(nginx|relay)$') - - if [ -n "$($dc ps -q relay 2>/dev/null)" ]; then - $dc restart relay - else - echo "Relay container not found, skipping restart." - fi + # Start the whole setup, except nginx, relay, and web. + start_service_and_wait_ready --remove-orphans $($dc config --services | grep -v -E '^(nginx|relay|web)$') if [ -n "$($dc ps -q nginx 2>/dev/null)" ]; then - $dc exec -T nginx nginx -s reload || true + # relay and web will be restarted as well, if we restart relay. + $dc restart nginx else - echo "Nginx container not found, skipping reload." + echo "Nginx container not found, skipping restart." fi $CONTAINER_ENGINE run --rm --network="${COMPOSE_PROJECT_NAME}_default" alpine ash \ From 0dff5500995bf936b23f9cea76877bebc62d6bca Mon Sep 17 00:00:00 2001 From: Reinaldy Rafli Date: Wed, 12 Aug 2026 11:24:40 +0700 Subject: [PATCH 2/3] fix: remove invalid flags for `docker compose down` --- install/turn-things-off.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install/turn-things-off.sh b/install/turn-things-off.sh index 8086726a323..69553389791 100644 --- a/install/turn-things-off.sh +++ b/install/turn-things-off.sh @@ -2,7 +2,7 @@ echo "${_group}Turning things off ..." if [[ -n "$MINIMIZE_DOWNTIME" ]]; then # Stop everything unless databases, relay, web, and nginx - $dc down -fsv $($dc config --services | grep -v -E '^(nginx|web|relay|smtp|memcached|redis|postgres|pgbouncer|kafka|clickhouse|seaweedfs)$') + $dc down $($dc config --services | grep -v -E '^(nginx|web|relay|smtp|memcached|redis|postgres|pgbouncer|kafka|clickhouse|seaweedfs)$') else # Clean up old stuff and ensure nothing is working while we install/update if [ "$CONTAINER_ENGINE" = "podman" ]; then From 36b2b1167662fb3c0d1c675f4d80d60a68415f73 Mon Sep 17 00:00:00 2001 From: Reinaldy Rafli Date: Sat, 15 Aug 2026 17:23:37 +0700 Subject: [PATCH 3/3] fix: revert wrap-up change --- install/wrap-up.sh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/install/wrap-up.sh b/install/wrap-up.sh index 45d748f9d8d..36fbc7d0ea3 100644 --- a/install/wrap-up.sh +++ b/install/wrap-up.sh @@ -2,13 +2,12 @@ if [[ "$MINIMIZE_DOWNTIME" ]]; then echo "${_group}Waiting for Sentry to start ..." # Start the whole setup, except nginx, relay, and web. - start_service_and_wait_ready --remove-orphans $($dc config --services | grep -v -E '^(nginx|relay|web)$') + start_service_and_wait_ready --remove-orphans $($dc config --services | grep -v -E '^(nginx|relay)$') if [ -n "$($dc ps -q nginx 2>/dev/null)" ]; then - # relay and web will be restarted as well, if we restart relay. - $dc restart nginx + $dc exec -T nginx nginx -s reload || true else - echo "Nginx container not found, skipping restart." + echo "Nginx container not found, skipping reload." fi $CONTAINER_ENGINE run --rm --network="${COMPOSE_PROJECT_NAME}_default" alpine ash \