From 27c01688ab50e4378606905a7abb46c6b778b8e1 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 23 Jul 2026 14:20:05 +0000 Subject: [PATCH] fix: notify user when redocking a panel with no song loaded MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit _redockPanel() deleted the popups entry and bailed silently when currentFilename was empty, dropping the popped-out panel's state with no feedback — unlike the overflow-drop path a few lines down, which already toasts. Addresses a CodeRabbit review comment on upstream got-feedBack/feedBack-plugin-splitscreen#23. --- screen.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/screen.js b/screen.js index 66c4d25..9599cbf 100644 --- a/screen.js +++ b/screen.js @@ -3906,7 +3906,10 @@ try { const entry = popups.get(popupId); if (!entry) return; popups.delete(popupId); - if (!currentFilename) return; + if (!currentFilename) { + _showMainToast('Could not dock panel — no song is currently loaded.'); + return; + } // A popup that split itself into multiple sub-panels sends `finalStates` // (one capture per sub-panel, in on-screen order); fall back to the