From 1cd516bbb1501df2ef425eebd459299577112876 Mon Sep 17 00:00:00 2001 From: Trinity Bee Date: Sun, 20 Sep 2026 15:46:26 +0000 Subject: [PATCH 1/2] salvage(queen-4356): commit what the turn left uncommitted The turn ended with these files edited and never committed. Uncommitted work is invisible to the review - it reads the branch - so the attempt would have been released as empty and the next bee would have started beside this work rather than from it. This commit is not a claim that the work is correct. It is the bee's work, committed on its behalf, and it is judged exactly like any other: the adversarial reviewer reads it, the compiler runs on it, and the issue's own criteria are measured against it. Issue: #4356 Turn: 68a42c79-d55d-4024-a11f-01c1ad65a510 Ending: finished (the turn closed) Committed: 1 path(s) Left uncommitted: 0 path(s) outside the declared boundary --- specs/ml/optimizer/adamw.t27 | 49 ++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/specs/ml/optimizer/adamw.t27 b/specs/ml/optimizer/adamw.t27 index 19c8794510..f709b3cd27 100644 --- a/specs/ml/optimizer/adamw.t27 +++ b/specs/ml/optimizer/adamw.t27 @@ -129,7 +129,11 @@ module AdamW; // amsgrad_update(v: gf16::GF16, v_max: gf16::GF16) → f32 // Computes AMSGrad maximum tracking. fn amsgrad_update(v: gf16::GF16, v_max: gf16::GF16) -> gf16::GF16 { - // return max(v_max, v) + if v > v_max { + v + } else { + v_max + } } // ═══════════════════════════════════════════════════════════ @@ -568,7 +572,7 @@ module AdamW; DEFAULT_BETA1 } - test get_effective_betas { + test get_effective_betas // Test Canonical variant given (b1, b2, wd) = get_effective_betas(PhiVariant.Canonical) then approximately_equal(b1, PHI_CANONICAL_BETA1) // ~ 0.618 @@ -592,37 +596,28 @@ module AdamW; then approximately_equal(b1, RATIONAL_BETA1) // 4/7 ~ 0.5714 and approximately_equal(b2, DEFAULT_BETA2) // 0.999 and approximately_equal(wd, RATIONAL_WEIGHT_DECAY) // 7/30 ~ 0.2333 - } - fn amsgrad_update(v: gf16::GF16, v_max: gf16::GF16) -> gf16::GF16 { - // return max(v_max, v) - when v > v_max { - v - } else { - v_max - } - } + - test amsgrad_update { - // Test when v > v_max - given result = amsgrad_update(5.0, 3.0) - then result == 5.0 +test amsgrad_update + // Test when v > v_max + given result = amsgrad_update(5.0, 3.0) + then result == 5.0 - // Test when v <= v_max - given result = amsgrad_update(2.0, 4.0) - then result == 4.0 + // Test when v <= v_max + given result = amsgrad_update(2.0, 4.0) + then result == 4.0 - // Test when v == v_max - given result = amsgrad_update(3.0, 3.0) - then result == 3.0 + // Test when v == v_max + given result = amsgrad_update(3.0, 3.0) + then result == 3.0 - // Test with negative values - given result = amsgrad_update(-1.0, -2.0) - then result == -1.0 + // Test with negative values + given result = amsgrad_update(-1.0, -2.0) + then result == -1.0 - given result = amsgrad_update(-3.0, -1.0) - then result == -1.0 - } + given result = amsgrad_update(-3.0, -1.0) + then result == -1.0 // ========================================================= // EXISTING TDD: Tests (preserved from pre-B1 spec) From 64e8be98695800a82b07a8f9f4c8d6444f7fbd50 Mon Sep 17 00:00:00 2001 From: "queen-publisher[bot]" Date: Mon, 21 Sep 2026 13:14:41 +0000 Subject: [PATCH 2/2] docs: the coordination entry this branch needs to land A pull request must add exactly one docs/now entry and a bee has no way to know that: its brief names a boundary file and acceptance criteria, and docs/now/ is neither. The publisher adds it rather than failing the gate. Closes #4356 Co-Authored-By: Claude Opus 5 --- ...t-2-of-3-of-the-empty-bodies-in-specs-ml-optimi.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 docs/now/2026-09-21-published-implement-part-2-of-3-of-the-empty-bodies-in-specs-ml-optimi.md diff --git a/docs/now/2026-09-21-published-implement-part-2-of-3-of-the-empty-bodies-in-specs-ml-optimi.md b/docs/now/2026-09-21-published-implement-part-2-of-3-of-the-empty-bodies-in-specs-ml-optimi.md new file mode 100644 index 0000000000..17d87ee97a --- /dev/null +++ b/docs/now/2026-09-21-published-implement-part-2-of-3-of-the-empty-bodies-in-specs-ml-optimi.md @@ -0,0 +1,11 @@ +# NOW -- Implement part 2 of 3 of the empty bodies in specs/ml/optimizer/adamw.t27 (8 functions) (published 2026-09-21) + +## A bee's work on #4356, published from `queen-4356` (Closes #4356) + +- The branch changes 1 file(s): `specs/ml/optimizer/adamw.t27`. +- `git diff --stat origin/master...queen-4356` reads: 1 file changed, 22 insertions(+), 27 deletions(-) +- This entry is written by the publisher, not by the bee. A pull request must + add exactly one `docs/now/` entry and a bee has no way to know that: its brief + names a boundary file and acceptance criteria, and `docs/now/` is neither. +- What this entry does NOT establish: that the work is correct. The gates on the + pull request judge that, and they are the same gates every other change meets.