From 6648eac34c456cd4b6c5a81e7b1b8f30d155be3d Mon Sep 17 00:00:00 2001 From: jjcav84 Date: Tue, 6 Oct 2026 22:05:28 -0500 Subject: [PATCH] fix(openai): keep full multi-message context in input.value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit _process_input_data ended with a redundant third write that reduced INPUT_VALUE to eval_input[0] — the first message's text only — after already writing the joined text of every message. Multi-turn and multi-part inputs lost all but the first content piece (#151). Drop the overwrite so the joined eval_input string survives; image parts still surface as {{input_images.N}} placeholders alongside INPUT_IMAGES. Generated with Devin Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- .../openai/traceai_openai/_span_io_handler.py | 1 - python/tests/test_framework_openai.py | 79 ++++++++++++++++++- 2 files changed, 78 insertions(+), 2 deletions(-) diff --git a/python/frameworks/openai/traceai_openai/_span_io_handler.py b/python/frameworks/openai/traceai_openai/_span_io_handler.py index a59508cbc..e363a5a21 100644 --- a/python/frameworks/openai/traceai_openai/_span_io_handler.py +++ b/python/frameworks/openai/traceai_openai/_span_io_handler.py @@ -62,7 +62,6 @@ def _process_input_data(input_data: Any, span: _WithSpan) -> None: eval_input_str = " \n ".join(map(str, eval_input)) span.set_attribute(SpanAttributes.INPUT_VALUE, eval_input_str) if eval_input and len(eval_input) > 0: - span.set_attribute(SpanAttributes.INPUT_VALUE, eval_input[0]) _set_mime_type(span, SpanAttributes.INPUT_MIME_TYPE, eval_input[0]) elif isinstance(input_data, str): # A bare prompt (e.g. Responses API ``input="..."``) is already the input diff --git a/python/tests/test_framework_openai.py b/python/tests/test_framework_openai.py index 5917a54f1..e0a20ba23 100644 --- a/python/tests/test_framework_openai.py +++ b/python/tests/test_framework_openai.py @@ -290,4 +290,81 @@ def test_instrumentor_uninstrumentation(self): # Methods should be restored (back to functions) assert openai.OpenAI.request == original_request - assert openai.AsyncOpenAI.request == original_async_request \ No newline at end of file + assert openai.AsyncOpenAI.request == original_async_request + +class TestProcessInputData: + """Unit tests for _process_input_data (issue #151 regression).""" + + @pytest.fixture + def span(self): + from traceai_openai._span_io_handler import _process_input_data + + mock = MagicMock() + yield mock, _process_input_data + + def test_multi_message_input_preserves_all_messages(self, span): + """INPUT_VALUE must keep every message's text, not just the first.""" + from fi_instrumentation.fi_types import SpanAttributes + + mock, process = span + process( + [ + {"role": "system", "content": "You are helpful."}, + {"role": "user", "content": "What is 2+2?"}, + {"role": "assistant", "content": "4"}, + {"role": "user", "content": "And 3+3?"}, + ], + mock, + ) + values = [ + c.args[1] + for c in mock.set_attribute.call_args_list + if c.args[0] == SpanAttributes.INPUT_VALUE + ] + final = values[-1] + for text in ("You are helpful.", "What is 2+2?", "4", "And 3+3?"): + assert text in final + + def test_multimodal_input_keeps_text_and_image_placeholders(self, span): + """Image parts become input_images placeholders inside the joined text.""" + from fi_instrumentation.fi_types import SpanAttributes + + mock, process = span + process( + [ + { + "role": "user", + "content": [ + {"type": "text", "text": "describe this"}, + { + "type": "image_url", + "image_url": {"url": "https://example.com/a.png"}, + }, + {"type": "text", "text": "in detail"}, + ], + } + ], + mock, + ) + attrs = {c.args[0]: c.args[1] for c in mock.set_attribute.call_args_list} + final = attrs[SpanAttributes.INPUT_VALUE] + assert "describe this" in final + assert "in detail" in final + assert f"{{{SpanAttributes.INPUT_IMAGES}.0}}" in final + assert "https://example.com/a.png" in attrs[SpanAttributes.INPUT_IMAGES] + + def test_single_message_still_sets_value(self, span): + from fi_instrumentation.fi_types import SpanAttributes + + mock, process = span + process([{"role": "user", "content": "hello"}], mock) + attrs = {c.args[0]: c.args[1] for c in mock.set_attribute.call_args_list} + assert "hello" in attrs[SpanAttributes.INPUT_VALUE] + + def test_non_list_input_serializes(self, span): + from fi_instrumentation.fi_types import SpanAttributes + + mock, process = span + process("plain prompt", mock) + attrs = {c.args[0]: c.args[1] for c in mock.set_attribute.call_args_list} + assert attrs[SpanAttributes.INPUT_VALUE] == '"plain prompt"'