From eb90666d50e1d3dd9465df084e39fe83d252a108 Mon Sep 17 00:00:00 2001 From: "svc-finitelabs[bot]" <269744575+svc-finitelabs[bot]@users.noreply.github.com> Date: Sat, 8 Aug 2026 13:41:15 -0500 Subject: [PATCH] build: drop the inert unnecessary-assert disable from the typecheck config The key was carried over from the config proposed in the #3 review on the assumption it was load-bearing on lua-language-server 3.18.2-dev. It is not: the review confirmed 11 problems either way there, with no such diagnostic emitted, and 3.19.0 agrees. A disabled diagnostic that never fires reads as a known exception to anyone changing this file later, so it is worse than nothing. Verified: `make typecheck` 11 problems in 3 files, unchanged; 15/15 modules; `make format-check` clean. --- .luarc-typecheck.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.luarc-typecheck.json b/.luarc-typecheck.json index e902932..a82e975 100644 --- a/.luarc-typecheck.json +++ b/.luarc-typecheck.json @@ -4,6 +4,5 @@ "useGitIgnore": false, "library": ["vendor"], "ignoreDir": [".claude", ".git", ".idea", ".venv", "build", "dist", "node_modules", "vendor"] - }, - "diagnostics": { "disable": ["unnecessary-assert"] } + } }