`start.sh` may force permissions change on mounted directories

[Trophime]

Hi,
I'm having some problems with start.sh script.
Imagine that I run feelpp/feelpp-toolboxes with this command line:

docker run -it --rm -v /home/me/data:/home/user/data -e LOCAL_USER_ID=`id -u $USER` ..

Since there is a chmod -R user.user $HOME in start.sh the permissions on /home/me/data will be forced to user.user which shall not append!

[prudhomm]

the id won't be changed since they (me and user) share the same id.

[prudhomm]

the idea is that user is actually me

[Trophime]

right but if you forget to add -e LOCAL_USER_ID=id -u $USER I have the pb.
I mean that in this case user is actually feelpp (aka 9001 id)
and then chmod -R user.user $HOME (run as root in docker) becomes problematic for directory data

[prudhomm]

indeed, we could detect that and avoid doing the chmod in that case.
but I think it would be bad practice to do like that (mounting in /home/user)!!
use /feel instead and you are done with this issue

[Trophime]

yep but at least there should be a clear WARNING to avoid mounting directory into /home/user

[prudhomm]

I agree.

[Trophime]

This kind of script may fix the problem

!/bin/bash

USER_ID=${LOCAL_USER_ID:-9001}

echo "Starting with UID : $USER_ID"
if [ "$USER_ID" != "9001" ]; then
   useradd -m -s /bin/bash -d /home/user -u $USER_ID -G sudo,video user
   echo "user ALL=(ALL) NOPASSWD: ALL" > /etc/sudoers.d/user

   # cp /home/feelpp/WELCOME /home/user
   cp -f /home/feelpp/.bash_aliases /home/user
   cp -f /home/feelpp/.bashrc /home/user

   # check for mounted directories in /home/user
   declare -a MountedDir
   declare -a MountedDirUid
   declare -a MountedDirGid

   for dir in $(find /home/user -type d); do
       status=$(mount -f | grep $dir); 
       if [ "x$status" != "x" ]; then 
           dir_uid=$(ls -gn $dir | awk  '{print $3}')
           dir_gid=$(ls -gn $dir | awk  '{print $3}')
           MountedDir=("${MountedDir[@]}" "$dir")
           MountedDirUid=("${MountedDirUid[@]}" "$dir_uid")      
           MountedDirGid=("${MountedDirGid[@]}" "$dir_gid")
           echo "!!! $dir(user=${dir_uid}, group=${dir_gid}  is mounted !!!" 
       fi
   done

   # Note this may be problematic if there are directories mounted in /home/user
   chown -R user.user /home/user

   # restore permissions on mounted directories if any
   for i in "${MountedDir[@]}"; do
       echo "Restore permissions on $MountedDir[$i]: $MountedUidDir[$i]:$MountedGidDir[$i]"
       chown $MountedUidDir[$i]:$MountedGidDir[$i] $MountedDir[$i]/*
       chown $MountedUidDir[$i]:$MountedGidDir[$i] $MountedDir[$i]/.
   done

   export HOME=/home/user
   exec /usr/sbin/gosu user bash
else
   export HOME=/home/user
   exec /usr/sbin/gosu feelpp bash
fi    

[prudhomm]

I will integrate that asap