From ae051bc584957d4072685307d3225bb534c8c5ba Mon Sep 17 00:00:00 2001 From: RugvedBane Date: Tue, 10 Nov 2026 12:22:18 +0530 Subject: [PATCH 1/2] FIX get_feature_names_out drops reference columns when drop_original=True --- feature_engine/_base_transformers/mixins.py | 7 ++++++- tests/test_creation/test_relative_features.py | 18 ++++++++++++++++++ .../test_datetime/test_datetime_subtraction.py | 17 +++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) diff --git a/feature_engine/_base_transformers/mixins.py b/feature_engine/_base_transformers/mixins.py index 9207873be..2f87d5ef0 100644 --- a/feature_engine/_base_transformers/mixins.py +++ b/feature_engine/_base_transformers/mixins.py @@ -179,7 +179,12 @@ def _add_new_feature_names(self, feature_names): if self.drop_original is True and self.variables_ is not None: # Remove names of variables to drop. - feature_names = [f for f in feature_names if f not in self.variables_] + if self.drop_original is True and self.variables_ is not None: + cols_to_drop = list(self.variables_) + ref = getattr(self, "reference_", None) or getattr(self, "reference", None) + if ref is not None: + cols_to_drop += [r for r in ref if r not in cols_to_drop] + feature_names = [f for f in feature_names if f not in cols_to_drop] return feature_names diff --git a/tests/test_creation/test_relative_features.py b/tests/test_creation/test_relative_features.py index dbfa4972c..385e2c895 100644 --- a/tests/test_creation/test_relative_features.py +++ b/tests/test_creation/test_relative_features.py @@ -459,3 +459,21 @@ def test_get_feature_names_out_raises_error_when_wrong_param( with pytest.raises(ValueError): transformer.get_feature_names_out(input_features=_input_features) + + +def test_get_feature_names_out_drop_original_excludes_reference(): + X = pd.DataFrame({"a": [1.0, 2.0], "b": [3.0, 4.0], "c": [5.0, 6.0]}) + t = RelativeFeatures( + variables=["a"], reference=["c"], func=["add"], drop_original=True + ) + t.fit(X) + assert t.get_feature_names_out() == ["b", "a_add_c"] + +def test_set_output_pandas_drop_original(): + X = pd.DataFrame({"a": [1.0, 2.0], "b": [3.0, 4.0], "c": [5.0, 6.0]}) + t = RelativeFeatures( + variables=["a"], reference=["c"], func=["add"], drop_original=True + ) + t.fit(X) + result = t.set_output(transform="pandas").transform(X) + assert list(result.columns) == ["b", "a_add_c"] \ No newline at end of file diff --git a/tests/test_datetime/test_datetime_subtraction.py b/tests/test_datetime/test_datetime_subtraction.py index 4e854d04e..98fead08a 100644 --- a/tests/test_datetime/test_datetime_subtraction.py +++ b/tests/test_datetime/test_datetime_subtraction.py @@ -377,3 +377,20 @@ def test_common_tests(estimator): check_feature_names_in(estimator) check_drop_original_variables(estimator) check_return_empty(estimator) + +def test_get_feature_names_out_drop_original_excludes_reference(): + X = pd.DataFrame({"end": ["2026-01-02"], "start": ["2026-01-01"]}) + transformer = DatetimeSubtraction( + variables=["end"], reference=["start"], drop_original=True + ) + transformer.fit(X) + assert transformer.get_feature_names_out() == ["end_sub_start"] + +def test_set_output_pandas_drop_original(): + X = pd.DataFrame({"end": ["2026-01-02"], "start": ["2026-01-01"]}) + transformer = DatetimeSubtraction( + variables=["end"], reference=["start"], drop_original=True + ) + transformer.fit(X) + result = transformer.set_output(transform="pandas").transform(X) + assert list(result.columns) == ["end_sub_start"] \ No newline at end of file From 0d347a179c36fa7d476736fc200a056322051c83 Mon Sep 17 00:00:00 2001 From: RugvedBane Date: Tue, 10 Nov 2026 12:43:26 +0530 Subject: [PATCH 2/2] FIX flake8 style errors --- feature_engine/_base_transformers/mixins.py | 4 +++- tests/test_creation/test_relative_features.py | 3 ++- tests/test_datetime/test_datetime_subtraction.py | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/feature_engine/_base_transformers/mixins.py b/feature_engine/_base_transformers/mixins.py index 2f87d5ef0..610137ca2 100644 --- a/feature_engine/_base_transformers/mixins.py +++ b/feature_engine/_base_transformers/mixins.py @@ -181,7 +181,9 @@ def _add_new_feature_names(self, feature_names): # Remove names of variables to drop. if self.drop_original is True and self.variables_ is not None: cols_to_drop = list(self.variables_) - ref = getattr(self, "reference_", None) or getattr(self, "reference", None) + ref = getattr(self, "reference_", None) or getattr( + self, "reference", None + ) if ref is not None: cols_to_drop += [r for r in ref if r not in cols_to_drop] feature_names = [f for f in feature_names if f not in cols_to_drop] diff --git a/tests/test_creation/test_relative_features.py b/tests/test_creation/test_relative_features.py index 385e2c895..538ea2639 100644 --- a/tests/test_creation/test_relative_features.py +++ b/tests/test_creation/test_relative_features.py @@ -469,6 +469,7 @@ def test_get_feature_names_out_drop_original_excludes_reference(): t.fit(X) assert t.get_feature_names_out() == ["b", "a_add_c"] + def test_set_output_pandas_drop_original(): X = pd.DataFrame({"a": [1.0, 2.0], "b": [3.0, 4.0], "c": [5.0, 6.0]}) t = RelativeFeatures( @@ -476,4 +477,4 @@ def test_set_output_pandas_drop_original(): ) t.fit(X) result = t.set_output(transform="pandas").transform(X) - assert list(result.columns) == ["b", "a_add_c"] \ No newline at end of file + assert list(result.columns) == ["b", "a_add_c"] diff --git a/tests/test_datetime/test_datetime_subtraction.py b/tests/test_datetime/test_datetime_subtraction.py index 98fead08a..c507778f9 100644 --- a/tests/test_datetime/test_datetime_subtraction.py +++ b/tests/test_datetime/test_datetime_subtraction.py @@ -378,6 +378,7 @@ def test_common_tests(estimator): check_drop_original_variables(estimator) check_return_empty(estimator) + def test_get_feature_names_out_drop_original_excludes_reference(): X = pd.DataFrame({"end": ["2026-01-02"], "start": ["2026-01-01"]}) transformer = DatetimeSubtraction( @@ -386,6 +387,7 @@ def test_get_feature_names_out_drop_original_excludes_reference(): transformer.fit(X) assert transformer.get_feature_names_out() == ["end_sub_start"] + def test_set_output_pandas_drop_original(): X = pd.DataFrame({"end": ["2026-01-02"], "start": ["2026-01-01"]}) transformer = DatetimeSubtraction( @@ -393,4 +395,4 @@ def test_set_output_pandas_drop_original(): ) transformer.fit(X) result = transformer.set_output(transform="pandas").transform(X) - assert list(result.columns) == ["end_sub_start"] \ No newline at end of file + assert list(result.columns) == ["end_sub_start"]