diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d85950a74..5d10bb3cd6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ Features: * Added opt-in drive health detection for NVMe disks, via udisks2 on Linux (no root required), NVMe SMART on macOS and the NVMe health log on Windows. (#2726, PhysicalDisk, Linux / macOS / Windows) * Enable it with `"health": true`. The default output appends `Health <100 - percentage used>%` and any critical warnings. * New format args: `{health}`, `{percent-used}`, `{available-spare}` and `{critical-warning}`. - * ATA disks report the SMART `failing` status as a critical warning. + * ATA disks report the SMART `failing` status as a critical warning (SAS and RAID disks stay unknown). On Windows and macOS, checking them may wake a sleeping HDD. Changes: * Improved PCI GPU name resolution by checking udev's hardware database and the NVIDIA driver's procfs before falling back to pci.ids. (GPU, Linux) diff --git a/doc/json_schema.json b/doc/json_schema.json index 92368db678..fe1b220652 100644 --- a/doc/json_schema.json +++ b/doc/json_schema.json @@ -453,7 +453,7 @@ "type": "string" }, "physicaldiskFormat": { - "description": "Output format for the `PhysicalDisk` module. See Wiki for formatting syntax\n 1. {size}: Device size (formatted)\n 2. {name}: Device name *\n 3. {interconnect}: Device interconnect type\n 4. {dev-path}: Device raw file path *\n 5. {serial}: Serial number\n 6. {physical-type}: Device kind (SSD or HDD)\n 7. {removable-type}: Device kind (Removable or Fixed)\n 8. {readonly-type}: Device kind (Read-only or Read-write)\n 9. {revision}: Product revision\n 10. {temperature}: Device temperature (formatted)\n 11. {health}: Device health, 100 - percentage used (formatted)\n 12. {percent-used}: Percentage of rated endurance used\n 13. {available-spare}: Remaining spare capacity\n 14. {critical-warning}: Critical warnings", + "description": "Output format for the `PhysicalDisk` module. See Wiki for formatting syntax\n 1. {size}: Device size (formatted)\n 2. {name}: Device name *\n 3. {interconnect}: Device interconnect type\n 4. {dev-path}: Device raw file path *\n 5. {serial}: Serial number\n 6. {physical-type}: Device kind (SSD or HDD)\n 7. {removable-type}: Device kind (Removable or Fixed)\n 8. {readonly-type}: Device kind (Read-only or Read-write)\n 9. {revision}: Product revision\n 10. {temperature}: Device temperature (formatted)\n 11. {health}: Device health, 100 - percentage used (formatted)\n 12. {percent-used}: Percentage of rated endurance used\n 13. {available-spare}: Remaining spare capacity\n 14. {critical-warning}: Critical warnings (NVMe warnings or ATA SMART failing status)", "type": "string" }, "physicalmemoryFormat": { @@ -3968,7 +3968,7 @@ "$ref": "#/$defs/temperature" }, "health": { - "description": "Whether to detect and display drive health (NVMe wear / SMART status), if supported", + "description": "Whether to detect and display drive health (NVMe wear / SMART status), if supported. On Windows and macOS, checking ATA disks may wake them from sleep", "type": "boolean", "default": false }, diff --git a/src/modules/physicaldisk/physicaldisk.c b/src/modules/physicaldisk/physicaldisk.c index 3ae14dfa20..e5fd8fd152 100644 --- a/src/modules/physicaldisk/physicaldisk.c +++ b/src/modules/physicaldisk/physicaldisk.c @@ -417,7 +417,7 @@ FFModuleBaseInfo ffPhysicalDiskModuleInfo = { { "Device health, 100 - percentage used (formatted)", "health" }, { "Percentage of rated endurance used", "percent-used" }, { "Remaining spare capacity", "available-spare" }, - { "Critical warnings (none if healthy)", "critical-warning" }, + { "Critical warnings (NVMe warnings or ATA SMART failing status)", "critical-warning" }, })), .defaultOrder = 69, };