From 36efb5b6994ecd2a22fca9664e48e15528f1b13b Mon Sep 17 00:00:00 2001 From: Johnathan Falk Date: Fri, 16 Oct 2026 10:17:02 -0400 Subject: [PATCH] fix(ci): move the fallback ghcommon script pin to 1f0d70e (github-common#374) Callers without .github/ghcommon-ref.txt ran e73b801's scripts, which predate changelog_file, so reusable-release.yml took the legacy inline-changelog path (uncapped, through env). 12 occurrences across 6 workflows; the only script change between the two SHAs is #374's release_workflow.py. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012mtQZQ26prebPvRBbC5wdL --- .github/guid-index.json | 12 ++++++------ .github/workflows/commit-override-handler.yml | 4 ++-- .github/workflows/reusable-advanced-cache.yml | 4 ++-- .github/workflows/reusable-ci.yml | 14 +++++++------- .github/workflows/reusable-maintenance.yml | 4 ++-- .github/workflows/reusable-release.yml | 8 ++++---- .github/workflows/reusable-security.yml | 4 ++-- .../20261016-ghcommon-script-pin-1f0d70e.md | 11 +++++++++++ 8 files changed, 36 insertions(+), 25 deletions(-) create mode 100644 changelog.d/20261016-ghcommon-script-pin-1f0d70e.md diff --git a/.github/guid-index.json b/.github/guid-index.json index 588df797..7d72d976 100644 --- a/.github/guid-index.json +++ b/.github/guid-index.json @@ -891,7 +891,7 @@ "path": ".github/workflows/commit-override-handler.yml", "guid": "7a8b9c0d-1e2f-3456-789a-bcdef0123456", "title": "Commit Override Handler", - "version": "1.3.5", + "version": "1.3.6", "header_path": ".github/workflows/commit-override-handler.yml", "path_mismatch": false }, @@ -963,7 +963,7 @@ "path": ".github/workflows/reusable-advanced-cache.yml", "guid": "e5f6a7b8-c9d0-1e2f-3a4b-5c6d7e8f9a0b", "title": "Reusable Advanced Caching", - "version": "1.1.5", + "version": "1.1.6", "header_path": ".github/workflows/reusable-advanced-cache.yml", "path_mismatch": false }, @@ -979,7 +979,7 @@ "path": ".github/workflows/reusable-ci.yml", "guid": "reusable-ci-2025-09-24-core-workflow", "title": "Reusable CI Workflow", - "version": "1.17.0", + "version": "1.17.1", "header_path": ".github/workflows/reusable-ci.yml", "path_mismatch": false }, @@ -995,7 +995,7 @@ "path": ".github/workflows/reusable-maintenance.yml", "guid": "reusable-maintenance-2025-09-24-core-workflow", "title": "Reusable Maintenance Workflow", - "version": "1.0.6", + "version": "1.0.7", "header_path": ".github/workflows/reusable-maintenance.yml", "path_mismatch": false }, @@ -1003,7 +1003,7 @@ "path": ".github/workflows/reusable-release.yml", "guid": "7b8c9d0e-1f2a-3b4c-5d6e-7f8a9b0c1d2e", "title": "Reusable Release Coordinator", - "version": "2.16.0", + "version": "2.16.1", "header_path": ".github/workflows/reusable-release.yml", "path_mismatch": false }, @@ -1011,7 +1011,7 @@ "path": ".github/workflows/reusable-security.yml", "guid": "reusable-security-2025-09-24-core-workflow", "title": "Reusable Security Workflow", - "version": "1.3.4", + "version": "1.3.5", "header_path": ".github/workflows/reusable-security.yml", "path_mismatch": false }, diff --git a/.github/workflows/commit-override-handler.yml b/.github/workflows/commit-override-handler.yml index 44ee8a8b..359a1c10 100644 --- a/.github/workflows/commit-override-handler.yml +++ b/.github/workflows/commit-override-handler.yml @@ -1,5 +1,5 @@ # file: .github/workflows/commit-override-handler.yml -# version: 1.3.5 +# version: 1.3.6 # guid: 7a8b9c0d-1e2f-3456-789a-bcdef0123456 # ⚠️ DO NOT EDIT DIRECTLY - This file is managed in ghcommon repository @@ -71,7 +71,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then ref="$(cat .github/ghcommon-ref.txt)" else - ref="e73b80106099118143806b0ce58e0a73cbcfb27c" + ref="1f0d70e877c89a21a597db5a24e2775d3015ddda" fi echo "ref=${ref}" >> "$GITHUB_OUTPUT" diff --git a/.github/workflows/reusable-advanced-cache.yml b/.github/workflows/reusable-advanced-cache.yml index b9a9adda..71455461 100644 --- a/.github/workflows/reusable-advanced-cache.yml +++ b/.github/workflows/reusable-advanced-cache.yml @@ -1,5 +1,5 @@ # file: .github/workflows/reusable-advanced-cache.yml -# version: 1.1.5 +# version: 1.1.6 # guid: e5f6a7b8-c9d0-1e2f-3a4b-5c6d7e8f9a0b name: Reusable Advanced Caching @@ -58,7 +58,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then echo "ref=$(cat .github/ghcommon-ref.txt)" >> "$GITHUB_OUTPUT" else - echo "ref=e73b80106099118143806b0ce58e0a73cbcfb27c" >> "$GITHUB_OUTPUT" + echo "ref=1f0d70e877c89a21a597db5a24e2775d3015ddda" >> "$GITHUB_OUTPUT" fi - name: Checkout ghcommon workflow scripts diff --git a/.github/workflows/reusable-ci.yml b/.github/workflows/reusable-ci.yml index 2b18ec21..90cb6403 100644 --- a/.github/workflows/reusable-ci.yml +++ b/.github/workflows/reusable-ci.yml @@ -1,7 +1,7 @@ # file: .github/workflows/reusable-ci.yml -# version: 1.17.0 +# version: 1.17.1 # guid: reusable-ci-2025-09-24-core-workflow -# last-edited: 2026-10-11 +# last-edited: 2026-10-16 name: Reusable CI Workflow @@ -599,7 +599,7 @@ jobs: # (e04c222, 2026-03-28) predated the rust-* commands added in 767acd4 # (2026-05-27), so every repo without the ref file failed Rust CI with # "Unknown command: rust-build". - ref="e73b80106099118143806b0ce58e0a73cbcfb27c" + ref="1f0d70e877c89a21a597db5a24e2775d3015ddda" fi echo "ref=$ref" >> "$GITHUB_OUTPUT" @@ -711,7 +711,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then ref="$(cat .github/ghcommon-ref.txt)" else - ref="e73b80106099118143806b0ce58e0a73cbcfb27c" + ref="1f0d70e877c89a21a597db5a24e2775d3015ddda" fi echo "ref=$ref" >> "$GITHUB_OUTPUT" @@ -777,7 +777,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then ref="$(cat .github/ghcommon-ref.txt)" else - ref="e73b80106099118143806b0ce58e0a73cbcfb27c" + ref="1f0d70e877c89a21a597db5a24e2775d3015ddda" fi echo "ref=$ref" >> "$GITHUB_OUTPUT" @@ -872,7 +872,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then ref="$(cat .github/ghcommon-ref.txt)" else - ref="e73b80106099118143806b0ce58e0a73cbcfb27c" + ref="1f0d70e877c89a21a597db5a24e2775d3015ddda" fi echo "ref=$ref" >> "$GITHUB_OUTPUT" @@ -1078,7 +1078,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then ref="$(cat .github/ghcommon-ref.txt)" else - ref="e73b80106099118143806b0ce58e0a73cbcfb27c" + ref="1f0d70e877c89a21a597db5a24e2775d3015ddda" fi echo "ref=$ref" >> "$GITHUB_OUTPUT" diff --git a/.github/workflows/reusable-maintenance.yml b/.github/workflows/reusable-maintenance.yml index 4002243e..c6024ed6 100644 --- a/.github/workflows/reusable-maintenance.yml +++ b/.github/workflows/reusable-maintenance.yml @@ -1,5 +1,5 @@ # file: .github/workflows/reusable-maintenance.yml -# version: 1.0.6 +# version: 1.0.7 # guid: reusable-maintenance-2025-09-24-core-workflow name: Reusable Maintenance Workflow @@ -50,7 +50,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then echo "ref=$(cat .github/ghcommon-ref.txt)" >> "$GITHUB_OUTPUT" else - echo "ref=e73b80106099118143806b0ce58e0a73cbcfb27c" >> "$GITHUB_OUTPUT" + echo "ref=1f0d70e877c89a21a597db5a24e2775d3015ddda" >> "$GITHUB_OUTPUT" fi - name: Checkout ghcommon workflow scripts diff --git a/.github/workflows/reusable-release.yml b/.github/workflows/reusable-release.yml index 420ea3a5..b2d5b784 100644 --- a/.github/workflows/reusable-release.yml +++ b/.github/workflows/reusable-release.yml @@ -1,5 +1,5 @@ # file: .github/workflows/reusable-release.yml -# version: 2.16.0 +# version: 2.16.1 # guid: 7b8c9d0e-1f2a-3b4c-5d6e-7f8a9b0c1d2e # last-edited: 2026-10-16 @@ -608,7 +608,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then echo "ref=$(cat .github/ghcommon-ref.txt)" >> "$GITHUB_OUTPUT" else - echo "ref=e73b80106099118143806b0ce58e0a73cbcfb27c" >> "$GITHUB_OUTPUT" + echo "ref=1f0d70e877c89a21a597db5a24e2775d3015ddda" >> "$GITHUB_OUTPUT" fi - name: Checkout ghcommon workflow scripts @@ -1101,7 +1101,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then echo "ref=$(cat .github/ghcommon-ref.txt)" >> "$GITHUB_OUTPUT" else - echo "ref=e73b80106099118143806b0ce58e0a73cbcfb27c" >> "$GITHUB_OUTPUT" + echo "ref=1f0d70e877c89a21a597db5a24e2775d3015ddda" >> "$GITHUB_OUTPUT" fi - name: Checkout ghcommon workflow scripts @@ -1272,7 +1272,7 @@ jobs: if [ -f .github/ghcommon-ref.txt ]; then echo "ref=$(cat .github/ghcommon-ref.txt)" >> "$GITHUB_OUTPUT" else - echo "ref=e73b80106099118143806b0ce58e0a73cbcfb27c" >> "$GITHUB_OUTPUT" + echo "ref=1f0d70e877c89a21a597db5a24e2775d3015ddda" >> "$GITHUB_OUTPUT" fi - name: Checkout ghcommon workflow scripts diff --git a/.github/workflows/reusable-security.yml b/.github/workflows/reusable-security.yml index 2f7e6b20..64cf9e7f 100644 --- a/.github/workflows/reusable-security.yml +++ b/.github/workflows/reusable-security.yml @@ -1,5 +1,5 @@ # file: .github/workflows/reusable-security.yml -# version: 1.3.4 +# version: 1.3.5 # guid: reusable-security-2025-09-24-core-workflow name: Reusable Security Workflow @@ -278,7 +278,7 @@ jobs: with: submodules: recursive repository: falkcorp/github-common - ref: e73b80106099118143806b0ce58e0a73cbcfb27c # v1.10.3+ + ref: 1f0d70e877c89a21a597db5a24e2775d3015ddda # main 2026-10-16 (github-common#374) path: .ghcommon sparse-checkout: | .github/scripts diff --git a/changelog.d/20261016-ghcommon-script-pin-1f0d70e.md b/changelog.d/20261016-ghcommon-script-pin-1f0d70e.md new file mode 100644 index 00000000..a6c15b92 --- /dev/null +++ b/changelog.d/20261016-ghcommon-script-pin-1f0d70e.md @@ -0,0 +1,11 @@ +### Fixed + +#### Fallback workflow-scripts pin moved to `1f0d70e`, so repos without `ghcommon-ref.txt` get capped, file-based release notes + +Every reusable workflow that checks out this repo's scripts, when the caller has +no `.github/ghcommon-ref.txt`, fell back to `e73b801`. That commit predates +github-common#374, so `reusable-release.yml` at `main` used its legacy inline +changelog path for those callers. That path is uncapped and passed through env, +so a long changelog still hit "Argument list too long". All 12 occurrences +across 6 workflows now point at `1f0d70e`, the #374 merge. The only script +change between the two commits is `release_workflow.py` from #374.