From 124ddb84b4e77e63382f0b7cb8a70d63dc9d86c4 Mon Sep 17 00:00:00 2001 From: Michel Lind Date: Tue, 15 Sep 2026 18:06:14 +0100 Subject: [PATCH] getdeps: honour --no-tests for cachelib cachelib's CMakeLists defaults BUILD_TESTS to ON and the manifest never overrode it, so `getdeps.py build --no-tests cachelib` still compiled every test binary. Wire the getdeps test context to BUILD_TESTS the same way the folly and fizz manifests do. With tests off the cachelib build on Fedora 44 drops from 497 to 110 ninja steps, which matters for memory- and CPU-constrained distro builders. Tested on Fedora 44 in a single `getdeps.py --allow-system-packages build --no-tests cachelib` run together with the Fedora rpm mappings from facebook/CacheLib#488 and the FindGlog config-mode fix; the resulting CMake cache has BUILD_TESTS:BOOL=OFF and the build succeeds. Co-Authored-By: Claude Fable 5.1 Signed-off-by: Michel Lind --- build/fbcode_builder/manifests/cachelib | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/build/fbcode_builder/manifests/cachelib b/build/fbcode_builder/manifests/cachelib index 0e89b16875..33f655d758 100644 --- a/build/fbcode_builder/manifests/cachelib +++ b/build/fbcode_builder/manifests/cachelib @@ -49,3 +49,9 @@ fbcode/cachelib/public_tld = . ^fbcode/cachelib/public_tld/website/node_modules(/|$) ^fbcode/cachelib/public_tld/website/build(/|$) ^fbcode/cachelib/public_tld/website/\.rewrite-lockfile\.fb$ + +[cmake.defines.test=on] +BUILD_TESTS=ON + +[cmake.defines.test=off] +BUILD_TESTS=OFF