From f12bb339fdfee0c602b15d895f9b4059a29bdc81 Mon Sep 17 00:00:00 2001 From: William Emfinger Date: Tue, 1 Sep 2026 19:49:35 -0500 Subject: [PATCH] fix(ci): move stream_frame ordering note out of the components block scalar MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The upload_components.yml components list is a YAML literal block scalar (components: |), so lines starting with # inside it are literal text, not comments — the upload-components-ci-action would receive the four-line "stream_frame is intentionally listed..." note as bogus component directory paths. This violates the file own rule ("comments are not allowed in the components list"). Move the explanation up into the # Note: block above the scalar (next to the ethernet and magnetic_encoder ordering notes) and drop the comment lines from inside the list. Component ordering is unchanged: stream_frame still precedes its first-time dependents coredump / dispatcher / ota. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/upload_components.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/upload_components.yml b/.github/workflows/upload_components.yml index 8092b6f79..5e8eb4b84 100755 --- a/.github/workflows/upload_components.yml +++ b/.github/workflows/upload_components.yml @@ -37,6 +37,10 @@ jobs: # mt6701, which depend on espp/magnetic_encoder, so it is # uploaded to the registry first. # + # Note: stream_frame is intentionally listed (out of alphabetical order) + # ahead of its first-time dependents coredump / dispatcher / ota, + # so it is uploaded to the registry before they try to resolve it. + # # Note: comments are not allowed in the "components" list, so please # do not add any comments here. components: | @@ -72,10 +76,6 @@ jobs: components/codec components/color components/controller - # stream_frame is intentionally listed here (out of alphabetical - # order) ahead of its first-time dependents coredump / dispatcher / - # ota, so it is uploaded before they try to resolve it from the - # registry (see the note above). components/stream_frame components/coredump components/cst816