From a0bbcdaa3e32477ceb6ef555c78359633e7282cf Mon Sep 17 00:00:00 2001 From: Reid Morrison Date: Sun, 15 Nov 2026 23:19:43 -0500 Subject: [PATCH 1/2] Test the newest Nx release in Linux CI CI only tests the Nx version in mix.lock (0.6.2), although Ortex now allows Nx 1.0. Since Nx 0.8 several operations, such as stack, call the backend directly, so problems that only show up on newer Nx go unnoticed. Add an "Nx latest" variant of the Linux job. It unlocks nx and complex (Nx 1.x needs complex 1.x) before fetching dependencies. Both variants now fetch only the test dependencies, because the dev-only exla and torchx 0.6 still require Nx 0.6 and would block resolving Nx 1.x. --- .github/workflows/ci.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e5953fe..3e8d94a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,11 +6,12 @@ on: jobs: linux: runs-on: ubuntu-latest - name: Linux ${{ matrix.elixir }}, ${{ matrix.otp }} + name: Linux ${{ matrix.elixir }}, ${{ matrix.otp }}, Nx ${{ matrix.nx }} strategy: matrix: elixir: ["1.17.3"] otp: ["27.1.2"] + nx: ["locked", "latest"] env: MIX_ENV: test steps: @@ -23,8 +24,13 @@ jobs: # (new cargo build-dir layout). Remove once ort is upgraded. - name: Pin Rust 1.99 run: rustup toolchain install 1.99.1 --profile minimal && rustup default 1.99.1 + # Nx 1.x needs complex 1.x. The dev-only exla/torchx 0.6 still require + # Nx 0.6, so only the test dependencies are fetched. + - name: Unlock Nx to test the newest release + if: matrix.nx == 'latest' + run: mix deps.unlock nx complex - name: Install dependencies - run: mix deps.get + run: mix deps.get --only test - name: Compile and check warnings run: mix compile --warnings-as-errors - name: Check formatting From ba616343a078b39a5676ee2a0411043e09b71528 Mon Sep 17 00:00:00 2001 From: Reid Morrison Date: Sun, 15 Nov 2026 23:36:18 -0500 Subject: [PATCH 2/2] Code Review: update Nx with its dependencies; don't cancel the other leg Answers /code-review high of ci-nx-latest at a0bbcda: - Unlocking "nx complex" by hand lists Nx's dependencies in the workflow. If a later Nx needs a newer version of another locked dependency, Hex quietly resolves an older Nx and the "latest" leg stops testing the newest release. "mix deps.update nx --only test" updates Nx together with its own dependencies. - The new two-leg matrix kept the default fail-fast, so a failure on "Nx latest" cancelled "Nx locked". Set fail-fast: false. --- .github/workflows/ci.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3e8d94a..89d099f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,6 +8,7 @@ jobs: runs-on: ubuntu-latest name: Linux ${{ matrix.elixir }}, ${{ matrix.otp }}, Nx ${{ matrix.nx }} strategy: + fail-fast: false matrix: elixir: ["1.17.3"] otp: ["27.1.2"] @@ -24,11 +25,11 @@ jobs: # (new cargo build-dir layout). Remove once ort is upgraded. - name: Pin Rust 1.99 run: rustup toolchain install 1.99.1 --profile minimal && rustup default 1.99.1 - # Nx 1.x needs complex 1.x. The dev-only exla/torchx 0.6 still require - # Nx 0.6, so only the test dependencies are fetched. - - name: Unlock Nx to test the newest release + # The dev-only exla/torchx 0.6 still require Nx 0.6, so only the test + # dependencies are updated and fetched. + - name: Update Nx to the newest release if: matrix.nx == 'latest' - run: mix deps.unlock nx complex + run: mix deps.update nx --only test - name: Install dependencies run: mix deps.get --only test - name: Compile and check warnings