From 19f6312741d4e5935845e86f5e97189a19b30e3c Mon Sep 17 00:00:00 2001 From: Nikola Radakovic Date: Fri, 30 Oct 2026 10:36:14 +0000 Subject: [PATCH] General cleanup Cleanup of unused functions, apis and commented code to satisfy clean code policy. --- BUILD | 12 ------------ rules/common.bzl | 17 ----------------- rules/gcc.bzl | 12 +++++++++--- tests/MODULE.bazel.lock | 2 +- 4 files changed, 10 insertions(+), 33 deletions(-) diff --git a/BUILD b/BUILD index 1f74f08..9b8bfb4 100644 --- a/BUILD +++ b/BUILD @@ -37,17 +37,5 @@ format_test( copyright_checker( name = "copyright", - # srcs = [ - # ".github", - # "docs", - # "examples", - # "packages", - # "rules", - # "templates", - # "tests", - # "tools", - # "//:BUILD", - # "//:MODULE.bazel", - # ], visibility = ["//visibility:public"], ) diff --git a/rules/common.bzl b/rules/common.bzl index cb5f610..083e652 100644 --- a/rules/common.bzl +++ b/rules/common.bzl @@ -57,23 +57,6 @@ def get_flag_groups(flags): return "[flag_group(flags = [" + ", ".join(['"%s"' % f for f in flags]) + "])]" return "[]" -def get_flag_group(flags): - """Helper function to create a flag_group. - - Args: - flags (list[str]): A list of compiler or linker flags. - - Returns: - flag_group: A Bazel flag_group object containing the provided flags. - """ - if len(flags): - return [ - flag_group( - flags = flags, - ), - ] - return [] - def label_list_to_string(input_list): """ Small helper function to transform label list into string list diff --git a/rules/gcc.bzl b/rules/gcc.bzl index fee70b2..05dd175 100644 --- a/rules/gcc.bzl +++ b/rules/gcc.bzl @@ -86,10 +86,16 @@ cc_toolchain_config( tc_extra_enabled_features = label_list_to_string(rctx.attr.extra_enabled_features), ) -def get_custom_cc_features_linux(rctx): - return "" - def get_custom_cc_features_qnx(rctx, canonical_pkg_name): + """Returns the QNX-specific feature loads and generated feature declarations. + + Args: + rctx: RepositoryContext object with toolchain attributes. + canonical_pkg_name: Canonical repository name of the toolchain package. + + Returns: + A tuple of the Starlark load statements and feature declarations. + """ # sdp_env's host_dir/target_dir must be plain resolved paths, not labels: # cc_args' `env` rejects format() variables that aren't builtin cc_toolchain # variables ("The variable host_dir does not exist"). diff --git a/tests/MODULE.bazel.lock b/tests/MODULE.bazel.lock index 08cd3ed..b559c85 100644 --- a/tests/MODULE.bazel.lock +++ b/tests/MODULE.bazel.lock @@ -1622,7 +1622,7 @@ }, "@@score_bazel_cpp_toolchains+//extensions:gcc.bzl%gcc": { "general": { - "bzlTransitiveDigest": "vfj6OANKO8MGGTTww1bLxSthdIlBi84NsJij5neM5Mk=", + "bzlTransitiveDigest": "1I2e6TN7UgYN/4Gn9FMDgAEhSRnvUeSkeX4MaiIcpY4=", "usagesDigest": "6tdL3YzS2zo0EaIGu0SKjN8CkeJGfj+W3K0kk1VS/ec=", "recordedFileInputs": {}, "recordedDirentsInputs": {},