From 1ff130fabb0ad5aafdb07c101eb7cea9aa42851c Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 1 Sep 2026 00:50:43 +0200 Subject: [PATCH] Style the progress bar in the dark theme MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bar had no rule of its own: only the ProgressIndicator around it was coloured, so the bar fell to the 'Composite > *' catch-all on DARK_BACKGROUND and did not separate from the chrome. Give it #5A5F62 as the trough and LINK_COLOR as the fill. The '.MPart' copies live in e4-dark_partstyle.css because they only tie '.MPart Composite > * > *' on specificity and need to be imported after it. Assisted-by: multiple AI agents and layers of automated tooling 🤖 --- .../css/dark/e4-dark_globalstyle.css | 11 ++++++++--- .../css/dark/e4-dark_partstyle.css | 9 +++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css b/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css index 81898ffd2a2..981dd1c3691 100644 --- a/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css +++ b/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css @@ -142,9 +142,14 @@ CompareViewerPane > * { color: '#org-eclipse-ui-workbench-DARK_FOREGROUND'; } -ProgressIndicator { - background-color: #777; - color: '#org-eclipse-ui-workbench-DARK_FOREGROUND'; +/* Element selectors match the exact widget class name, so the bars inside a + * ProgressIndicator need the child selector. Inside a part the bar is styled by + * the '.MPart' copies in e4-dark_partstyle.css. */ +ProgressIndicator, +ProgressIndicator > *, +ProgressBar { + background-color: #5A5F62; + color: '#org-eclipse-ui-workbench-LINK_COLOR'; } DiscoveryItem, diff --git a/bundles/org.eclipse.ui.themes/css/dark/e4-dark_partstyle.css b/bundles/org.eclipse.ui.themes/css/dark/e4-dark_partstyle.css index 946ac02a565..b1cbacfc890 100644 --- a/bundles/org.eclipse.ui.themes/css/dark/e4-dark_partstyle.css +++ b/bundles/org.eclipse.ui.themes/css/dark/e4-dark_partstyle.css @@ -60,6 +60,15 @@ } +/* Ties '.MPart Composite > * > *' above on specificity, so it has to sit after + * it. Keep in step with the ProgressBar rule in e4-dark_globalstyle.css. */ +.MPart ProgressIndicator, +.MPart ProgressIndicator > *, +.MPart ProgressBar { + background-color: #5A5F62; + color: '#org-eclipse-ui-workbench-LINK_COLOR'; +} + .MPart Section > Label { background-color: #2F2F2F; color: #ABCEDA;