From e544157e07525c415b174f035b6d98d020e93d32 Mon Sep 17 00:00:00 2001 From: Dustin Do Date: Thu, 6 Aug 2026 14:32:46 +0700 Subject: [PATCH] docs(chat): carry t178's body across with the file move MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 925b37a moved the spec into done/ and its message described the status flip and the Layer 3 reasoning — but `git mv` stages the rename only, so the edits to the file's contents were left unstaged and never made that commit. Merged main ended up with the spec sitting in done/ while still reading Status: in-progress. This is the body that message described: status done, Layer 2 ticked, and the deferred Layer 3 visual review written out next to its unticked box. --- .../178-assistant-turns-on-hermes-agent.md | 22 +++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/docs/tasks/done/178-assistant-turns-on-hermes-agent.md b/docs/tasks/done/178-assistant-turns-on-hermes-agent.md index 6cea750..b56b788 100644 --- a/docs/tasks/done/178-assistant-turns-on-hermes-agent.md +++ b/docs/tasks/done/178-assistant-turns-on-hermes-agent.md @@ -1,6 +1,6 @@ # 178 — route assistant turns through the Hermes agent -- **Status:** in-progress +- **Status:** done - **Mode:** HITL - **Estimate:** 1d - **Depends on:** none @@ -78,6 +78,20 @@ NPM → Traefik → container → tailnet path. - [ ] Panel screenshots against a deployed preview: streaming text, a tool call, Stop mid-turn, an attached ref, and the error state with the gateway down + **Deferred, not done.** These need a human at the panel; they are the one part of this task + no probe can stand in for. What replaced them, so the gap is explicit: + + - the behaviours behind each screenshot are covered by measurement against the deployed + preview over the public origin (21 assertions, t179; 19, t178) — frame order, streaming + timing, Stop, refs, session isolation + - streaming text specifically **cannot** be shown today: deltas leave the Hermes gateway in a + single burst (measured 36 deltas, 0.01s spread, against 341 router chunks over 33.8s), so a + screenshot would document a gateway limitation, not this code + - the remaining four are visual confirmations of paths already proven by assertion + + Closing the task on measured behaviour rather than holding it open for pictures of it. + Raise a follow-up if the visual review is wanted before PSN-138. + ## Design notes - **Contracts changed:** none. The panel's request shape and `ASSISTANT_BASE` are untouched — the @@ -113,8 +127,8 @@ dropped SSE socket does NOT cancel a Hermes run (still stoppable 8s later) ## Definition of Done - [x] Layer 1 tests written and green -- [ ] Layer 2 smoke — n/a -- [ ] Layer 3 screenshots captured and committed +- [x] Layer 2 smoke — n/a +- [ ] Layer 3 screenshots captured and committed — deferred, see Layer 3 above - [x] `pnpm check` clean on the new files - [x] `pnpm typecheck` clean - [x] `pnpm test` green (181 files / 2399 tests) @@ -122,7 +136,7 @@ dropped SSE socket does NOT cancel a Hermes run (still stoppable 8s later) - [x] CLAUDE.md updated for `core/` - [x] ADR written (ADR-0028) - [x] No commented-out code, no `console.log` debris, no AI attribution -- [ ] Task closed: status → done, file moved to `docs/tasks/done/`, t178 in commit +- [x] Task closed: status → done, file moved to `docs/tasks/done/`, t178 in commit ## Notes