From c20bb7b3ed156cb8fd37c6730c53c23ccbbe862d Mon Sep 17 00:00:00 2001
From: Cody Guldner <codyguldner@dropbox.com>
Date: Fri, 17 Jul 2026 14:03:35 -0500
Subject: [PATCH] Close old spec-update PRs after creating new one with link

Move the close step after PR creation so it can comment
"Superseded by #<new>" on each old PR before closing it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 .github/workflows/spec_update.yml | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/spec_update.yml b/.github/workflows/spec_update.yml
index dc8a7645..2fe6a885 100644
--- a/.github/workflows/spec_update.yml
+++ b/.github/workflows/spec_update.yml
@@ -85,16 +85,6 @@ jobs:
           pip install -r requirements.txt
           python generate_base_client.py
 
-      - name: Close Old Pull Requests
-        if: steps.git-diff-num.outputs.num-diff != 0
-        run: |
-          gh pr list --label "automated-spec-update" --state open --json number --jq '.[].number' | while read -r pr_num; do
-            echo "Closing old PR #$pr_num"
-            gh pr close "$pr_num" --delete-branch
-          done
-        env:
-          GH_TOKEN: ${{ steps.app-token.outputs.token }}
-
       - name: Create Pull Request
         id: create-pr
         uses: peter-evans/create-pull-request@v8
@@ -113,6 +103,19 @@ jobs:
             automated-spec-update
           draft: false
 
+      - name: Close Old Pull Requests
+        if: steps.create-pr.outputs.pull-request-number
+        run: |
+          gh pr list --label "automated-spec-update" --state open --json number --jq '.[].number' | while read -r pr_num; do
+            if [ "$pr_num" != "${{ steps.create-pr.outputs.pull-request-number }}" ]; then
+              echo "Closing old PR #$pr_num"
+              gh pr comment "$pr_num" --body "Superseded by #${{ steps.create-pr.outputs.pull-request-number }}"
+              gh pr close "$pr_num" --delete-branch
+            fi
+          done
+        env:
+          GH_TOKEN: ${{ steps.app-token.outputs.token }}
+
       # - name: Enable Pull Request Automerge
       #   if: steps.create-pr.outputs.pull-request-number
       #   run: gh pr merge --merge --auto "${{ steps.create-pr.outputs.pull-request-number }}"