diff --git a/docs/specs/layout.md b/docs/specs/layout.md index 703e5ffd0..04343075d 100644 --- a/docs/specs/layout.md +++ b/docs/specs/layout.md @@ -258,7 +258,7 @@ A mode or selection change, or a kill confirmation, takes it down. Chrome outside every Wall takes the chrome keyboard lease instead: the Workspace strip's rename editor, close confirmation, and tab menu live in the app bar, where `stopPropagation` cannot reach a capture-phase window listener. The Workspace branch is inert on a Wall with no Workspace id. -**Must leave Escape and Tab to IME composition in modal/popover focus traps and terminal-context dialogs, and Enter/Escape in shared inline editors** (`isComposingKey` in `lib/src/lib/dom.ts`). +**Must leave Escape and Tab to IME composition in modal/popover focus traps, and Enter/Escape in shared inline editors** (`isComposingKey` in `lib/src/lib/dom.ts`). Source of truth: `useWallKeyboard` in `lib/src/components/wall/use-wall-keyboard.ts`; `acquireChromeKeyboardLease` in `lib/src/components/wall/chrome-keyboard-lease.ts`; `handleStrayKey` in `lib/src/components/wall/keyboard/handle-stray-key.ts`. diff --git a/docs/specs/security-supply-chain.rationale.md b/docs/specs/security-supply-chain.rationale.md index f2434ce8a..74a170e97 100644 --- a/docs/specs/security-supply-chain.rationale.md +++ b/docs/specs/security-supply-chain.rationale.md @@ -36,7 +36,7 @@ Why the release build keeps pnpm's runtime: `build.rs` bundles the `node` on `PA What the `minimumReleaseAge` package rules are: the Renovate equivalent of the pnpm dependency cooldown window, applied per manager. -The pgstencil exception has a different gate: its release workflow stages a version only after a passing `security-audit` on the packaged commit, and a human approves the staged package with npm 2FA before it becomes public. The package carries that commit in `dist/provenance.json`; Hosted verifies matching clean commits for core and auth, and its audit checks npm-signed workflow attestations bind those bytes to that commit. The exclusion list is deliberately narrow so other dependencies retain the withdrawal window. +The pgstencil exception has a different gate: its release workflow stages a version only after a passing `security-audit` on the packaged commit, and a human approves the staged package with npm 2FA before it becomes public. The package carries that commit in `dist/provenance.json`; Hosted verifies matching clean commits for core, auth, and stripe, and its audit checks npm-signed workflow attestations bind those bytes to that commit. The exclusion list is deliberately narrow so other dependencies retain the withdrawal window. Why the `vulnerabilityAlerts` cooldown is kept rather than dropped for speed: it guards the opposite threat from the alert itself — a compromised release that gets yanked within a day, which a reviewer reading a dependency diff cannot detect the way the ecosystem's own yank process can. Nothing here auto-merges, and the Dependabot alert already makes the vulnerability visible the moment it is published, so what the cooldown costs is a day before the remediation PR appears, not a day before anyone knows. diff --git a/docs/specs/terminal-context.md b/docs/specs/terminal-context.md index 8089d5402..c3cf3a538 100644 --- a/docs/specs/terminal-context.md +++ b/docs/specs/terminal-context.md @@ -13,7 +13,7 @@ - **Must hide a retained helper without terminating its PTY**; revealing or promoting reuses the same xterm element. Renderer resource lifetime follows `docs/specs/layout.md` → "Renderer". - **Must keep a helper's directory independent of its source**, showing both locations prominently when they differ. Unknown directory state is not evidence of a match. - **Must retain exited output**, offer Reset, and avoid automatic restart loops. -- **Must pause status and process-inspection polling while the context is hidden**, its Workspace out of view included. Reopening publishes current terminal status; source closure inspects work on demand. +- **Must pause exit and process-inspection polling while the context is hidden**, its Workspace out of view included. Reopening publishes a helper's exit; source closure inspects work on demand. **Must make Reset an explicit discard**, confirmed first; under Labs it asks nothing and the old helper becomes a pending kill (`docs/specs/reopen.md` → "Labs: No-confirm delayed kill"), which the host stops counting as the source's one helper until a restore re-owns it. Cancellation changes nothing; confirmation disposes the old helper and launches a fresh one in the source's current directory. diff --git a/dor-tools-builtin/viewer/image/icons.tsx b/dor-tools-builtin/viewer/image/icons.tsx index 37cda4190..cad801a33 100644 --- a/dor-tools-builtin/viewer/image/icons.tsx +++ b/dor-tools-builtin/viewer/image/icons.tsx @@ -20,7 +20,6 @@ const paths = { redo: <>, square: , round: , - close: , }; export type IconName = keyof typeof paths; diff --git a/dor-tools-builtin/viewer/image/image.css b/dor-tools-builtin/viewer/image/image.css index 1ee71a5c0..039185748 100644 --- a/dor-tools-builtin/viewer/image/image.css +++ b/dor-tools-builtin/viewer/image/image.css @@ -1,6 +1,6 @@ /* The image editor on the workbench's --vscode-* variables: two dense rows of - * chrome, then the canvas. It fills the box its host gives it. The options row - * never wraps, so switching tools never moves the canvas: as the editor + * chrome, then the canvas. It fills the box its host gives it. Above 500px the + * options row never wraps, so switching tools never moves the canvas: as the editor * narrows, its readouts drop out first (the container queries at the end), * with the host's controls marked `ie-optional`; Save's own enabled state * still says whether there are edits. */ diff --git a/website/src/components/SiteHeader.tsx b/website/src/components/SiteHeader.tsx index 8352bdf30..1a8738f56 100644 --- a/website/src/components/SiteHeader.tsx +++ b/website/src/components/SiteHeader.tsx @@ -14,7 +14,7 @@ export const STATIC_PAGE_HEADER_STYLE: React.CSSProperties = { export const PRELAUNCH_NOTICE = "Pre-launch — word of mouth only, please. No top-level forum posts."; type SiteHeaderProps = Omit, "links" | "notice"> & { - /** Show the pre-launch strip (Home and the reference pages). */ + /** Show the pre-launch strip (Home, the docs, and the policy pages). */ prelaunch?: boolean; };