diff --git a/src/corner/core.py b/src/corner/core.py index 0b160d2..6716ae2 100644 --- a/src/corner/core.py +++ b/src/corner/core.py @@ -890,7 +890,8 @@ def overplot_points(fig, xs, reverse=False, **kwargs): """ kwargs["marker"] = kwargs.pop("marker", ".") - kwargs["linestyle"] = kwargs.pop("linestyle", "none") + if "ls" not in kwargs and "linestyle" not in kwargs: + kwargs["linestyle"] = "none" xs = _parse_input(xs) K = len(xs) axes, _ = _get_fig_axes(fig, K) diff --git a/tests/test_overplot_alias.py b/tests/test_overplot_alias.py new file mode 100644 index 0000000..769af79 --- /dev/null +++ b/tests/test_overplot_alias.py @@ -0,0 +1,49 @@ +# -*- coding: utf-8 -*- + +import numpy as np +import pytest +from matplotlib import pyplot as pl + +import corner + + +@pytest.mark.parametrize("reverse", [False, True]) +@pytest.mark.parametrize("linestyle", ["--", ":", "none"]) +def test_overplot_points_linestyle_alias(reverse, linestyle): + samples = np.random.default_rng(42).normal(size=(100, 2)) + points = np.array([[0.1, 0.4], [0.3, 0.2], [0.5, -0.1]]) + fig = corner.corner(samples, reverse=reverse) + try: + ax = fig.axes[1 if reverse else 2] + corner.overplot_points( + fig, points, reverse=reverse, ls=linestyle, c="C2", marker="s" + ) + alias_line = ax.lines[-1] + corner.overplot_points( + fig, + points, + reverse=reverse, + linestyle=linestyle, + color="C2", + marker="s", + ) + full_line = ax.lines[-1] + np.testing.assert_array_equal(alias_line.get_xdata(), points[:, 0]) + np.testing.assert_array_equal(alias_line.get_ydata(), points[:, 1]) + assert alias_line.get_linestyle() == full_line.get_linestyle() + assert alias_line.get_color() == full_line.get_color() + assert alias_line.get_marker() == full_line.get_marker() + finally: + pl.close(fig) + + +def test_overplot_points_default_linestyle(): + fig = corner.corner(np.random.default_rng(42).normal(size=(100, 2))) + try: + corner.overplot_points(fig, [[0.1, 0.2], [0.3, 0.4]]) + assert fig.axes[2].lines[-1].get_linestyle() == "None" + assert fig.axes[2].lines[-1].get_marker() == "." + with pytest.raises(TypeError, match="aliases"): + corner.overplot_points(fig, [[0.1, 0.2]], ls="--", linestyle=":") + finally: + pl.close(fig)