[Bug]: skipping usage of pre-existing nanolayer

[keturn]

Feature id and version

ghcr.io/devcontainers-extra/features/bun:1

Dev Container base Image

mcr.microsoft.com/devcontainers/javascript-node:4-24-trixie

What happened?

Note this isn't specific to the bun feature, I think it happens with any of them that use nanolayer.

I see this message:

skipping usage of pre-existing nanolayer. (required version v0.5.6 does not match existing version 0.5.6)

which seems nonsensical, but now I notice one of them has the v in front.

[keturn]

The normalization code looks right to me:

features/src/bun/library_scripts.sh

Lines 124 to 126 in b771bce

	if ! [[ $current_version == v* ]]; then
	current_version=v$current_version
	fi

so I'm not sure why that logic is failing.

[nkaaf]

@keturn I observe the same behaviour and debugged the whole toolchain for this. But I probably found the solution for the bug. The problem is not that the library_scripts.sh of bun or others (I debugged ruff) is incorrect, but the one from the gh-release feature.

Explanation:

• the bun/install.sh file executes the ensure_nanolayer function of the bun/library_scripts.sh file
  

  features/src/bun/install.sh

  Line 17 in 7afd88a

  ensure_nanolayer nanolayer_location "v0.5.6"

• nanolayer is downloaded, "unzipped" and the location is saved. The nanolayer output in the build script is printed by
  

  features/src/bun/library_scripts.sh

  Line 160 in 7afd88a

  tar xfzv $tmp_dir/$tar_filename -C "$tmp_dir"

  • example output from ruff feature installation:

#14 0.223 ===========================================================================
#14 0.223 Feature       : Ruff (via Github Releases)
#14 0.223 Description   : Ruff is an extremely fast Python linter, written in Rust.
#14 0.223 Id            : ghcr.io/devcontainers-extra/features/ruff
#14 0.223 Version       : 2.0.0
#14 0.223 Documentation : http://github.com/devcontainers-extra/features/tree/main/src/ruff
#14 0.223 Options       :
#14 0.223     VERSION="latest"
#14 0.223 ===========================================================================
#14 3.795 nanolayer

• After this, nanolayer is downloaded and is executed and installs the gh_release feature here
  

  features/src/bun/install.sh

  Lines 211 to 220 in 7afd88a

  	if $nanolayer_location \
  	install \
  	devcontainer-feature \
  	"ghcr.io/devcontainers-extra/features/gh-release:1" \
  	--option repo='oven-sh/bun' \
  	--option binaryNames='bun' \
  	--option version="$version_for_release" \
  	--option assetRegex="$asset_regex" \
  	--option releaseTagRegex="$release_tag_regex" 2>&1; then
  	return 0

• The gh-release feature receives some environment variables by the nanolayer execution that points to the location of the nanolayer binary. With this variables, the gh-release/install.sh ensures that nanolayer is installed
  

  features/src/gh-release/install.sh

  Line 11 in 7afd88a

  ensure_nanolayer nanolayer_location "v0.5.6"

• But it does not have the normalization steps of the version number, like e.g. the bun feature:
  

  features/src/gh-release/library_scripts.sh

  Lines 97 to 127 in 7afd88a

  	ensure_nanolayer() {
  	# Ensure existance of the nanolayer cli program
  	local variable_name=$1
  	local required_version=$2
  	local __nanolayer_location=""
  	# If possible - try to use an already installed nanolayer
  	if [ -z "${NANOLAYER_FORCE_CLI_INSTALLATION}" ]; then
  	if [ -z "${NANOLAYER_CLI_LOCATION}" ]; then
  	if type nanolayer >/dev/null 2>&1; then
  	echo "Found a pre-existing nanolayer in PATH"
  	__nanolayer_location=nanolayer
  	fi
  	elif [ -f "${NANOLAYER_CLI_LOCATION}" ] && [ -x "${NANOLAYER_CLI_LOCATION}" ] ; then
  	__nanolayer_location=${NANOLAYER_CLI_LOCATION}
  	echo "Found a pre-existing nanolayer which were given in env variable: $__nanolayer_location"
  	fi
  	# make sure its of the required version
  	if ! [ -z "${__nanolayer_location}" ]; then
  	local current_version
  	current_version=$($__nanolayer_location --version)
  	if ! [ $current_version == $required_version ]; then
  	echo "skipping usage of pre-existing nanolayer. (required version $required_version does not match existing version $current_version)"
  	__nanolayer_location=""
  	fi
  	fi

I will create a PR for this issue and link it