From 2adeb80e8b4575af0e5f9f28bdae32a2bf20f3ff Mon Sep 17 00:00:00 2001 From: abacus_fixer Date: Sat, 29 Aug 2026 17:25:35 +0800 Subject: [PATCH 1/2] Fix undefined basis variable in interface workflow (#7571) The "Create mock data & patch script" step referenced `basis` inside the Python heredoc without defining it: the matrix key `basis` was never exported to the step environment, so the step failed with "NameError: name 'basis' is not defined" before any mock data was generated. Pass matrix.basis through the BASIS environment variable and read it in the heredoc, matching the existing SCRIPT/PREFIX pattern. --- .github/workflows/interface.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/interface.yml b/.github/workflows/interface.yml index 5e1b59d026..d89f2aa3a0 100644 --- a/.github/workflows/interface.yml +++ b/.github/workflows/interface.yml @@ -58,12 +58,14 @@ jobs: env: SCRIPT: ${{ matrix.script }} PREFIX: ${{ matrix.prefix }} + BASIS: ${{ matrix.basis }} run: | python3 << 'PYEOF' import os, re, textwrap script = os.environ["SCRIPT"] prefix = os.environ["PREFIX"] + basis = os.environ["BASIS"] # ── 1. Patch the example script ──────────────────────── with open(script) as f: From 658a4e1efa5af264c1c1edaf45dd8ac65edd7502 Mon Sep 17 00:00:00 2001 From: abacus_fixer Date: Sat, 29 Aug 2026 17:43:21 +0800 Subject: [PATCH 2/2] Add Upstream Repository section to AGENTS.md Document the upstream repo/issues/PR links and two workflow facts: upstream PRs are opened from personal fork branches, and workflow_dispatch-only workflows cannot be verified by PR CI. --- AGENTS.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/AGENTS.md b/AGENTS.md index 5da0070bb4..43a46de7d3 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -112,6 +112,17 @@ The repository text files have been normalized to LF once. Day-to-day line ending enforcement should rely on staged/changed-file hooks and CI; rerun the full mixed-line-ending hook only for intentional repository-wide normalization. +## Upstream Repository + +- Repository: https://github.com/deepmodeling/abacus-develop +- Issues: https://github.com/deepmodeling/abacus-develop/issues +- Pull requests: https://github.com/deepmodeling/abacus-develop/pulls +- Upstream PRs are opened from personal fork branches + (`:` into `develop`). +- `workflow_dispatch`-only workflows (e.g. `.github/workflows/interface.yml`) + are not triggered by push/PR events; PR CI cannot verify such fixes, so + state "manual dispatch run required" in the PR verification notes. + ## PR Self-Check - Confirm the PR body states exact commands run, whether they passed or failed,