After PR #7888 and PR #7900 were merged, building with MPI and unit tests enabled fails:
error: ‘world_communication_domain’ is not a member of ‘ModuleBase’
PR #7900 renamed ModuleBase::world_communication_domain() to ModuleBase::world_comm_domain(), but five calls introduced by PR #7888 still use the old name.
Reproduction
With the required build dependencies configured:
cmake -S . -B build -DENABLE_MPI=ON -DBUILD_TESTING=ON
cmake --build build -j32
Affected files
Under source/source_base/test_parallel/:
test_para_gemm.cpp:77parallel_device_test.cpp:127parallel_domain_grid_test.cpp:17,31,49
Suggested fix
Update these five calls to ModuleBase::world_comm_domain(), then rebuild and run the affected tests.
PR #7888 and PR #7900 each passed their pre-merge CI without including the other's changes. The post-merge CMake Build Test used BUILD_TESTING=OFF, so it did not catch this incompatibility. PR #7900 CI, PR #7888 CI, post-merge build.
After PR #7888 and PR #7900 were merged, building with MPI and unit tests enabled fails:
PR #7900 renamed
ModuleBase::world_communication_domain()toModuleBase::world_comm_domain(), but five calls introduced by PR #7888 still use the old name.Reproduction
With the required build dependencies configured:
cmake -S . -B build -DENABLE_MPI=ON -DBUILD_TESTING=ON cmake --build build -j32Affected files
Under
source/source_base/test_parallel/:test_para_gemm.cpp:77parallel_device_test.cpp:127parallel_domain_grid_test.cpp:17,31,49Suggested fix
Update these five calls to
ModuleBase::world_comm_domain(), then rebuild and run the affected tests.PR #7888 and PR #7900 each passed their pre-merge CI without including the other's changes. The post-merge CMake Build Test used
BUILD_TESTING=OFF, so it did not catch this incompatibility. PR #7900 CI, PR #7888 CI, post-merge build.