From 85138450e193a038b4474d9ec73d8aa39109ad01 Mon Sep 17 00:00:00 2001 From: Viktor Voytovych Date: Thu, 12 Nov 2026 19:18:04 +0200 Subject: [PATCH] ci: run Test Alerts on every pull request, so it can be a required check A required check that a paths filter skips stays pending, so the path-filtered workflow could not be required. The filter is removed: the alert-rule tests run on every pull request and every push to main. A run takes 11-13 s, against 5-7 minutes for the main CI workflow, so the filter saved little. --- .github/workflows/test-alerts.yaml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test-alerts.yaml b/.github/workflows/test-alerts.yaml index 6b812d53..913c981d 100644 --- a/.github/workflows/test-alerts.yaml +++ b/.github/workflows/test-alerts.yaml @@ -2,22 +2,15 @@ name: Test Alerts # Runs every alert-rule test under test/alerts/ against the VMRule it extracts, # so a change to an alert's expression or labels cannot merge untested. +# +# It runs on every pull request, with no paths filter, so that it can be a +# required check: a required check that a paths filter skips stays pending. on: pull_request: - paths: - - '.github/workflows/test-alerts.yaml' - - 'config/components/alerts/**' - - 'test/alerts/**' - - 'Taskfile.yaml' push: branches: - main - paths: - - '.github/workflows/test-alerts.yaml' - - 'config/components/alerts/**' - - 'test/alerts/**' - - 'Taskfile.yaml' concurrency: group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.ref || github.sha }}