From 0fd3d5dd45e9f11662d3a25473172504f19745b6 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 31 Jul 2026 11:29:27 +0000 Subject: [PATCH] perf(resolver): short-circuit jargon and noise checking in quality scoring Optimizes `_check_jargon` and `_compute_noise` in `scripts/quality.py` and its shadow copy in the skill directory to return early as soon as the threshold is exceeded. This avoids redundant substring counting over large resolved text documents. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com> --- .../do-web-doc-resolver/scripts/quality.py | 16 ++++++++++++---- scripts/quality.py | 16 ++++++++++++---- 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/.agents/skills/do-web-doc-resolver/scripts/quality.py b/.agents/skills/do-web-doc-resolver/scripts/quality.py index de6fc171..b7150095 100644 --- a/.agents/skills/do-web-doc-resolver/scripts/quality.py +++ b/.agents/skills/do-web-doc-resolver/scripts/quality.py @@ -86,8 +86,12 @@ def _check_jargon(text_lower: str) -> bool: "transform", "supercharge", ] - jargon_count = sum(text_lower.count(signal) for signal in jargon_signals) - return jargon_count > THRESHOLD_JARGON + jargon_count = 0 + for signal in jargon_signals: + jargon_count += text_lower.count(signal) + if jargon_count > THRESHOLD_JARGON: + return True + return False def _check_frontmatter(text: str) -> bool: @@ -115,8 +119,12 @@ def _check_anchors(text: str) -> bool: def _compute_noise(text_lower: str) -> bool: """Detect noisy signals like cookie/subscribe prompts.""" noisy_signals = ["cookie", "subscribe", "javascript", "log in", "sign up"] - noise_count = sum(text_lower.count(signal) for signal in noisy_signals) - return noise_count > THRESHOLD_NOISE + noise_count = 0 + for signal in noisy_signals: + noise_count += text_lower.count(signal) + if noise_count > THRESHOLD_NOISE: + return True + return False def is_bot_challenge(content: str) -> bool: diff --git a/scripts/quality.py b/scripts/quality.py index 9ee6b6ff..ff8db32f 100644 --- a/scripts/quality.py +++ b/scripts/quality.py @@ -86,8 +86,12 @@ def _check_jargon(text_lower: str) -> bool: "transform", "supercharge", ] - jargon_count = sum(text_lower.count(signal) for signal in jargon_signals) - return jargon_count > THRESHOLD_JARGON + jargon_count = 0 + for signal in jargon_signals: + jargon_count += text_lower.count(signal) + if jargon_count > THRESHOLD_JARGON: + return True + return False def _check_frontmatter(text: str) -> bool: @@ -115,8 +119,12 @@ def _check_anchors(text: str) -> bool: def _compute_noise(text_lower: str) -> bool: """Detect noisy signals like cookie/subscribe prompts.""" noisy_signals = ["cookie", "subscribe", "javascript", "log in", "sign up"] - noise_count = sum(text_lower.count(signal) for signal in noisy_signals) - return noise_count > THRESHOLD_NOISE + noise_count = 0 + for signal in noisy_signals: + noise_count += text_lower.count(signal) + if noise_count > THRESHOLD_NOISE: + return True + return False def is_bot_challenge(content: str) -> bool: