Pass release constants into the Homebrew tap generator

release.sh already owned the repo, binary, formula, and description; the tap generator hard-coded copies of the same values. It now takes them from the environment release.sh sets, so they cannot drift.

Author: TheGreatAxios

scripts/generate-homebrew-tap.ts

@@ -11,18 +11,26 @@ export interface HomebrewRelease {
   checksums: Record<Platform, string>;
 }
 
-const releaseURL = (version: string, platform: Platform): string =>
-  `https://github.com/corbitsdev/corbits-code/releases/download/v${version}/corbits-${version}-${platform}.tar.gz`;
+/** Release facts owned by scripts/release.sh; passed in so they live in one place. */
+export interface HomebrewPackage {
+  repo: string; // GitHub owner/name
+  binary: string; // CLI binary, tarball stem, and legacy formula name
+  formula: string; // `brew install` name
+  description: string;
+}
+
+const formulaClass = (formula: string): string =>
+  formula.replace(/(?:^|-)([a-z])/g, (_, c: string) => c.toUpperCase());
 
-function renderFormula(release: HomebrewRelease): string {
+function renderFormula(pkg: HomebrewPackage, release: HomebrewRelease): string {
   const source = (
     platform: Platform,
-  ): string => `      url "${releaseURL(release.version, platform)}"
+  ): string => `      url "https://github.com/${pkg.repo}/releases/download/v${release.version}/${pkg.binary}-${release.version}-${platform}.tar.gz"
       sha256 "${release.checksums[platform]}"`;
 
-  return `class CorbitsCode < Formula
-  desc "Single-process coding agent CLI built on the Interchange runtime"
-  homepage "https://github.com/corbitsdev/corbits-code"
+  return `class ${formulaClass(pkg.formula)} < Formula
+  desc "${pkg.description}"
+  homepage "https://github.com/${pkg.repo}"
   version "${release.version}"
   license "GPL-2.0-only"
 
@@ -45,15 +53,15 @@ ${source("linux-x64")}
   end
 
   def install
-    bin.install "corbits"
+    bin.install "${pkg.binary}"
     if File.directory?("plugins")
       (bin/"plugins").mkpath
       cp_r "plugins/.", bin/"plugins"
     end
   end
 
   test do
-    assert_predicate bin/"corbits", :executable?
+    assert_predicate bin/"${pkg.binary}", :executable?
   end
 end
 `;
@@ -79,17 +87,21 @@ async function readFormulaRenames(path: string): Promise<Record<string, string>>
   return renames;
 }
 
-export async function generateHomebrewTap(tapDir: string, release: HomebrewRelease): Promise<void> {
+export async function generateHomebrewTap(
+  tapDir: string,
+  pkg: HomebrewPackage,
+  release: HomebrewRelease,
+): Promise<void> {
   const formulaDir = join(tapDir, "Formula");
   const renamesPath = join(tapDir, "formula_renames.json");
-  const formula = renderFormula(release);
+  const formula = renderFormula(pkg, release);
   const renames = await readFormulaRenames(renamesPath);
-  renames.corbits = "corbits-code";
+  renames[pkg.binary] = pkg.formula;
   const renameMetadata = `${JSON.stringify(renames, null, 2)}\n`;
 
   await mkdir(formulaDir, { recursive: true });
-  await rm(join(formulaDir, "corbits.rb"), { force: true });
-  await writeFile(join(formulaDir, "corbits-code.rb"), formula);
+  await rm(join(formulaDir, `${pkg.binary}.rb`), { force: true });
+  await writeFile(join(formulaDir, `${pkg.formula}.rb`), formula);
   await writeFile(renamesPath, renameMetadata);
 }
 
@@ -128,7 +140,22 @@ function parseRelease(args: string[]): { tapDir: string; release: HomebrewReleas
   };
 }
 
+function requireEnv(name: string): string {
+  const value = process.env[name];
+  if (!value) throw new Error(`missing ${name} (set by scripts/release.sh)`);
+  return value;
+}
+
 if (import.meta.main) {
   const { tapDir, release } = parseRelease(process.argv.slice(2));
-  await generateHomebrewTap(tapDir, release);
+  await generateHomebrewTap(
+    tapDir,
+    {
+      repo: requireEnv("MAIN_REPO"),
+      binary: requireEnv("BINARY"),
+      formula: requireEnv("BREW_FORMULA"),
+      description: requireEnv("DESC"),
+    },
+    release,
+  );
 }

scripts/release.sh

@@ -483,7 +483,8 @@ else
   sha_for() {  # sha_for LABEL -> sha256 of that tarball
     cut -d' ' -f1 "$STAGE/$BINARY-$VERSION-$1.tar.gz.sha256"
   }
-  bun "$ROOT/scripts/generate-homebrew-tap.ts" \
+  MAIN_REPO="$MAIN_REPO" BINARY="$BINARY" BREW_FORMULA="$BREW_FORMULA" DESC="$DESC" \
+    bun "$ROOT/scripts/generate-homebrew-tap.ts" \
     "$TAP_DIR" \
     "$VERSION" \
     "$(sha_for macos-arm64)" \

tests/unit/generate-homebrew-tap.test.ts

@@ -5,6 +5,13 @@ import { join } from "node:path";
 
 import { generateHomebrewTap } from "../../scripts/generate-homebrew-tap.js";
 
+const pkg = {
+  repo: "corbitsdev/corbits-code",
+  binary: "corbits",
+  formula: "corbits-code",
+  description: "Single-process coding agent CLI built on the Interchange runtime",
+};
+
 const release = {
   version: "1.2.3",
   checksums: {
@@ -31,7 +38,7 @@ describe("generateHomebrewTap", () => {
     await mkdir(formulaDir);
     await writeFile(join(formulaDir, "corbits.rb"), "class Corbits < Formula\nend\n");
 
-    await generateHomebrewTap(tapDir, release);
+    await generateHomebrewTap(tapDir, pkg, release);
 
     expect((await readdir(formulaDir)).sort()).toEqual(["corbits-code.rb"]);
     const formula = await readFile(join(formulaDir, "corbits-code.rb"), "utf8");
@@ -54,7 +61,7 @@ describe("generateHomebrewTap", () => {
       await writeFile(join(formulaDir, "corbits-code.rb"), currentFormula);
       await writeFile(join(caseDir, "formula_renames.json"), metadata);
 
-      await expect(generateHomebrewTap(caseDir, release)).rejects.toThrow(
+      await expect(generateHomebrewTap(caseDir, pkg, release)).rejects.toThrow(
         "Invalid formula rename metadata",
       );
 
@@ -69,15 +76,15 @@ describe("generateHomebrewTap", () => {
       `${JSON.stringify({ retained: "other-formula" }, null, 2)}\n`,
     );
 
-    await generateHomebrewTap(tapDir, release);
+    await generateHomebrewTap(tapDir, pkg, release);
 
     const first = await readFile(join(tapDir, "formula_renames.json"), "utf8");
     expect(JSON.parse(first)).toEqual({
       retained: "other-formula",
       corbits: "corbits-code",
     });
 
-    await generateHomebrewTap(tapDir, release);
+    await generateHomebrewTap(tapDir, pkg, release);
     expect(await readFile(join(tapDir, "formula_renames.json"), "utf8")).toBe(first);
   });
 });