Keep type-to-filter overlays open on no-match Enter

acceptOverlaySelection closed before onAccept could refuse the empty-id
sentinel, so the resume picker vanished on a failed filter. Refuse the
sentinel at accept time. Slash-popup Enter on zero matches still
dismisses.

Author: TheGreatAxios

src/tui/list-modal.test.ts

@@ -89,7 +89,14 @@ describe("runListModal", () => {
     expect(harness.captureCharFrame()).toContain("(no matches)");
     harness.pressKey("Enter");
     await harness.renderOnce();
-    harness.pressKey("Escape");
-    expect(await choice).toBeNull();
+    const afterEnter = harness.captureCharFrame();
+    expect(afterEnter).toContain("(no matches)");
+    expect(afterEnter).toContain(">");
+    for (let i = 0; i < 5; i++) {
+      harness.pressKey("Backspace");
+    }
+    await harness.renderOnce();
+    harness.pressKey("Enter");
+    expect(await choice).toBe("s-1");
   });
 });

src/tui/list-modal.ts

@@ -108,8 +108,7 @@ export async function runListModal(config: ListModalConfig): Promise<string | nu
     ...(config.typeToFilter === true ? { typeToFilter: true } : {}),
     onAccept: (selection) => {
       const id = residualIdFromSelection(selection, itemIds);
-      // Type-to-filter plants "(no matches)" with an empty id. Stay open.
-      if (id === undefined || id.length === 0) return;
+      if (id === undefined) return;
       settle(id);
     },
   });

src/tui/overlays.test.ts

@@ -2,7 +2,7 @@
  * Wave 5: primary overlays — open / navigate / Esc restore + resize floors.
  */
 import { describe, expect, test } from "bun:test";
-import { rgbToHex } from "@opentui/core";
+import { rgbToHex, type KeyEvent } from "@opentui/core";
 import { IDLE_TRANSCRIPT_FLOOR, OVERLAY_TRANSCRIPT_FLOOR } from "./geometry/index";
 import { focusOwner, scrollLease } from "./focus/index";
 import { withTestRenderer } from "./harness";
@@ -18,6 +18,7 @@ import {
   clearShellOverlayHooks,
   closeInsetOverlay,
   createAppShell,
+  handleListFilterKey,
   moveOverlaySelection,
   openListOverlay,
   pageOverlaySelection,
@@ -450,6 +451,44 @@ describe("overlay accept callbacks", () => {
   });
 });
 
+describe("type-to-filter list overlay", () => {
+  test("no-match Enter leaves overlayList set and does not echo Chose (no matches)", async () => {
+    await withTestRenderer(
+      async (h) => {
+        const shell = createAppShell(h.renderer, {
+          terminal: { columns: 80, rows: 24 },
+          wireKeys: false,
+        });
+        try {
+          openListOverlay(shell, {
+            kind: "resume",
+            items: ["First session", "Second session"],
+            itemIds: ["s-1", "s-2"],
+            typeToFilter: true,
+          });
+          const press = (seq: string): boolean =>
+            handleListFilterKey(shell, {
+              name: seq,
+              sequence: seq,
+              ctrl: false,
+              meta: false,
+              option: false,
+            } as unknown as KeyEvent);
+          for (const ch of "zzzzz") press(ch);
+          expect(shell.overlayItems).toEqual(["(no matches)"]);
+          acceptOverlaySelection(shell);
+          expect(shell.overlayList).not.toBeNull();
+          expect(shell.overlayItems).toEqual(["(no matches)"]);
+          expect(shell.streamLog.some((row) => /Chose \(no matches\)/.test(row.text))).toBe(false);
+        } finally {
+          shell.dispose();
+        }
+      },
+      { width: 80, height: 24 },
+    );
+  });
+});
+
 describe("resize mid-overlay", () => {
   test("80×24 ↔ larger keeps floors; closed restores idle floor", async () => {
     await withTestRenderer(

src/tui/palette-paint.test.ts

@@ -9,6 +9,7 @@ import type { KeyEvent } from "@opentui/core";
 import { withTestRenderer } from "./harness";
 import type { PaletteCommand } from "./command-catalog";
 import {
+  acceptOverlaySelection,
   createAppShell,
   handlePaletteFilterKey,
   moveOverlaySelection,
@@ -183,6 +184,17 @@ describe("palette filters as you type", () => {
       expect(shell.overlayKind).toBe("palette");
     });
   });
+
+  test("type-to-filter no-match Enter leaves the palette open", async () => {
+    await withPalette((shell) => {
+      for (const ch of "zzqq") press(shell, ch);
+      expect(shell.overlayItems).toEqual(["(no matches)"]);
+      acceptOverlaySelection(shell);
+      expect(shell.overlayKind).toBe("palette");
+      expect(shell.overlayList).not.toBeNull();
+      expect(shell.overlayItems).toEqual(["(no matches)"]);
+    });
+  });
 });
 
 const DESCRIBED_CATALOG: readonly PaletteCommand[] = [

src/tui/product-host.test.ts

@@ -569,6 +569,8 @@ describe("flat type-to-filter model picker", () => {
       expect(host.shell.overlayItems).toEqual(["(no matches)"]);
       acceptOverlaySelection(host.shell);
       expect(selected).toEqual([]);
+      expect(host.shell.overlayList).not.toBeNull();
+      expect(host.shell.overlayItems).toEqual(["(no matches)"]);
     } finally {
       host.dispose();
       harness.destroy();

src/tui/product-host.ts

@@ -576,7 +576,7 @@ export async function mountProductHost(config: ProductHostConfig): Promise<Produ
           // back to `items[sel.index]` — that index is into the filtered list,
           // not the unfiltered catalog, so it would pick the wrong model.
           const id = sel.id;
-          if (id === undefined || id.length === 0) return;
+          if (id === undefined) return;
           onSelect(id);
         },
         describe: (itemId) => currentDescribeModel?.(itemId) ?? null,

src/tui/shell.ts

@@ -4338,22 +4338,25 @@ export function acceptOverlaySelection(shell: AppShell): void {
   const idx = shell.overlayList.activeIndex;
   const label = shell.overlayItems[idx] ?? `item ${idx}`;
   const kind = shell.overlayKind ?? "demo";
+  const bag = internals.get(shell);
 
   if (kind === "palette") {
     const cmd = shell.paletteCommands[idx];
-    closeInsetOverlay(shell);
-    if (cmd) dispatchPaletteSelection(shell, cmd);
-    else {
-      appendStreamRow(shell, {
-        role: "system",
-        text: `palette: no action for ${label}`,
-      });
+    if (!cmd) {
+      // Type-to-filter plants a "(no matches)" row with no command. Stay open.
+      // Slash popup (`typeToFilter: false`) still closes — intentional dismiss.
+      if (bag?.paletteFilter?.typeToFilter === true && !isSlashPopupOpen(shell)) return;
+      closeInsetOverlay(shell);
+      return;
     }
+    closeInsetOverlay(shell);
+    dispatchPaletteSelection(shell, cmd);
     return;
   }
 
-  const bag = internals.get(shell);
   const id = bag?.overlayItemIds[idx];
+  // Type-to-filter plants "(no matches)" with an empty-id sentinel. Stay open.
+  if (id === "") return;
   const value = bag?.overlayItemValues[idx];
   const selection: OverlaySelection = {
     kind,