Resolve gate overlays on Esc instead of hanging

Esc on a permission or operator overlay called closeInsetOverlay,
which dropped the accept callback without ever invoking the caller's
awaited resolve. The run deadlocked until the process was killed.

Add an onCancel hook to the overlay opts and thread it through
openListOverlay and closeInsetOverlay for the promise-backed overlay
kinds only, so gate-wire can resolve deny/cancel from it. Deliberate
accept and answer-submit paths null the hook first so closing there
does not also fire it. Update the operator "no way to answer" copy
now that Esc actually settles the question.

Author: TheGreatAxios

src/tui-opentui/gate-wire.test.ts

@@ -9,6 +9,7 @@ import { withTestRenderer, type Harness } from "./harness.js"
 import { OVERLAY_MAX_FRACTION } from "./geometry/index.js"
 import {
   acceptOverlaySelection,
+  closeInsetOverlay,
   createAppShell,
   exitOverlayAnswerMode,
   handleOverlayAnswerKey,
@@ -523,6 +524,71 @@ describe("permission.gate auto-deny", () => {
   })
 })
 
+describe("Esc on a gate overlay settles the awaited promise", () => {
+  test("permission.gate: Esc denies instead of abandoning the promise", async () => {
+    await withTestRenderer(async (h) => {
+      const shell = createAppShell(h.renderer, {
+        terminal: { columns: 80, rows: 24 },
+        run: "idle",
+      })
+      const emitter = new EventEmitter()
+      let resolved: unknown
+      let resolveCount = 0
+      try {
+        wireGates(emitter, shell)
+        emitter.emit("permission.gate", {
+          request: baseRequest(),
+          resolve: (outcome: unknown) => {
+            resolveCount += 1
+            resolved = outcome
+          },
+        })
+        expect(shell.overlayKind).toBe("permissions")
+
+        closeInsetOverlay(shell)
+
+        expect(shell.overlayList).toBeNull()
+        expect(resolveCount).toBe(1)
+        expect(resolved).toEqual({ allow: false })
+      } finally {
+        shell.dispose()
+      }
+    })
+  })
+
+  test("operator.gate: Esc cancels instead of abandoning the promise", async () => {
+    await withTestRenderer(async (h) => {
+      const shell = createAppShell(h.renderer, {
+        terminal: { columns: 80, rows: 24 },
+        run: "idle",
+      })
+      const emitter = new EventEmitter()
+      let resolved: unknown
+      let resolveCount = 0
+      try {
+        wireGates(emitter, shell)
+        emitter.emit("operator.gate", {
+          question: "Proceed?",
+          options: ["Cancel", "Continue"],
+          resolve: (result: unknown) => {
+            resolveCount += 1
+            resolved = result
+          },
+        })
+        expect(shell.overlayKind).toBe("operator")
+
+        closeInsetOverlay(shell)
+
+        expect(shell.overlayList).toBeNull()
+        expect(resolveCount).toBe(1)
+        expect(resolved).toEqual({ kind: "cancel" })
+      } finally {
+        shell.dispose()
+      }
+    })
+  })
+})
+
 describe("permission overlay height", () => {
   const openGate = (shell: AppShell, scopeCount: number): void => {
     const emitter = new EventEmitter()

src/tui-opentui/gate-wire.ts

@@ -300,6 +300,19 @@ export function wireGates(
           recordDecision(shell, ev.request, choices, gateSelection)
           ev.resolve(approvalOutcomeFromSelection(choices, gateSelection))
         },
+        // Esc must settle the awaited promise (as a deny), not abandon it —
+        // an unresolved gate hangs the run until the process is killed.
+        onCancel: () => {
+          if (settled) return
+          settled = true
+          clearTimers()
+          ev.resolve(
+            approvalOutcomeFromSelection(choices, {
+              index: 0,
+              id: PERMISSION_DENY_ID,
+            }),
+          )
+        },
       })
     }
 
@@ -360,6 +373,9 @@ export function wireGates(
       // The ask_operator contract offers a free-form answer, so the overlay
       // must be able to send one back rather than only an option index.
       onTextAnswer: (text: string) => ev.resolve(operatorCustomResult(text)),
+      // Esc must settle the awaited promise (as a cancel), not abandon it —
+      // an unresolved gate hangs the run until the process is killed.
+      onCancel: () => ev.resolve(operatorCancelResult()),
     }))
   }
 

src/tui-opentui/overlays.ts

@@ -89,6 +89,8 @@ export type OpenPermissionsOpts = {
   readonly onAccept?: (selection: OverlaySelection) => void
   /** Per-open expand/collapse of collapsed command payloads. */
   readonly onToggleExpand?: () => void
+  /** Per-open Esc/dismiss; host binds resolve(ApprovalOutcome) so Esc denies instead of hanging. */
+  readonly onCancel?: () => void
 }
 
 export function openPermissionsOverlay(
@@ -108,6 +110,7 @@ export function openPermissionsOverlay(
       ? { onToggleExpand: opts.onToggleExpand }
       : {}),
     ...(opts?.onAccept !== undefined ? { onAccept: opts.onAccept } : {}),
+    ...(opts?.onCancel !== undefined ? { onCancel: opts.onCancel } : {}),
   })
 }
 
@@ -120,6 +123,8 @@ export type OpenOperatorOpts = {
   readonly onAccept?: (selection: OverlaySelection) => void
   /** Per-open free-text answer; host binds the custom OperatorResult. */
   readonly onTextAnswer?: (text: string) => void
+  /** Per-open Esc/dismiss; host binds resolve(cancel) so Esc cancels instead of hanging. */
+  readonly onCancel?: () => void
 }
 
 /**
@@ -128,7 +133,7 @@ export type OpenOperatorOpts = {
  * offering "Enter choose" against an empty list.
  */
 const NO_WAY_TO_ANSWER =
-  "No options were offered and this question takes no typed answer. Press Esc to dismiss it."
+  "No options were offered and this question takes no typed answer. Press Esc to cancel it."
 
 export function openOperatorOverlay(
   shell: AppShell,
@@ -150,6 +155,7 @@ export function openOperatorOverlay(
     ...(opts?.onTextAnswer !== undefined
       ? { onTextAnswer: opts.onTextAnswer }
       : {}),
+    ...(opts?.onCancel !== undefined ? { onCancel: opts.onCancel } : {}),
   })
 }
 

src/tui-opentui/shell.ts

@@ -1685,6 +1685,7 @@ type PriorOverlaySnapshot = {
   readonly onAction: ((itemId: string, key: KeyEvent) => boolean) | null
   readonly answer: OverlayAnswerState | null
   readonly titleText: string
+  readonly onCancel: (() => void) | null
 }
 
 type ShellInternals = {
@@ -1712,6 +1713,12 @@ type ShellInternals = {
   overlayAnswer: OverlayAnswerState | null
   /** Bare title of the open overlay, so its key hints can be re-composed. */
   overlayTitleText: string
+  /**
+   * Per-open dismiss hook for promise-backed overlays (permissions, operator).
+   * Esc/closeInsetOverlay invokes this instead of silently dropping the
+   * pending promise the way palette/mentions/copy overlays correctly do.
+   */
+  overlayOnCancel: (() => void) | null
   /** Fired once the shell has no overlay open, so queued gates can re-open. */
   overlayClosedListeners: Set<() => void>
   /**
@@ -2715,6 +2722,12 @@ export type OpenListOverlayOpts = {
    * Scoped to this open only, the way `onToggleExpand` and `typeToFilter` are.
    */
   readonly onCycle?: (itemId: string, direction: -1 | 1) => void
+  /**
+   * Per-open Esc/dismiss hook for promise-backed overlays (permissions,
+   * operator). Invoked by closeInsetOverlay before the accept path is
+   * cleared, so the caller's awaited promise resolves instead of hanging.
+   */
+  readonly onCancel?: () => void
   /**
    * Description-zone source. Called with the focused item's id on every move
    * (falling back to its label when no `itemIds` were supplied). Returning
@@ -2788,6 +2801,7 @@ export function openListOverlay(
           onAction: bag.overlayOnAction,
           answer: bag.overlayAnswer,
           titleText: bag.overlayTitleText,
+          onCancel: bag.overlayOnCancel,
         }
       }
       // Leave prior overlay focus frame; palette will stack above it.
@@ -2816,6 +2830,7 @@ export function openListOverlay(
       bag.overlayOnCycle = opts?.onCycle ?? null
       bag.overlayDescribe = opts?.describe ?? null
       bag.overlayOnAction = opts?.onAction ?? null
+      bag.overlayOnCancel = opts?.onCancel ?? null
     } else if (!bag.priorOverlay) {
       // Bare palette (no primary under it): no accept payload.
       bag.overlayItemIds = opts?.itemIds ? [...opts.itemIds] : []
@@ -2825,6 +2840,7 @@ export function openListOverlay(
       bag.overlayOnCycle = opts?.onCycle ?? null
       bag.overlayDescribe = opts?.describe ?? null
       bag.overlayOnAction = opts?.onAction ?? null
+      bag.overlayOnCancel = opts?.onCancel ?? null
     }
     if (!isPalette) {
       bag.overlayAnswer =
@@ -3072,6 +3088,10 @@ export function handleOverlayAnswerKey(
       text: `answered: ${text}`,
       meta: "overlay",
     })
+    // Deliberate submit, not a dismiss — closeInsetOverlay must not also fire
+    // the Esc/cancel path.
+    const bag = internals.get(shell)
+    if (bag) bag.overlayOnCancel = null
     closeInsetOverlay(shell)
     submit(text)
     return true
@@ -3157,6 +3177,13 @@ export function closeInsetOverlay(shell: AppShell): void {
   }
   const bag = internals.get(shell)
   const prior = wasPalette ? bag?.priorOverlay ?? null : null
+  // Permissions/operator overlays back a caller awaiting ev.resolve — Esc must
+  // still settle that promise (as a deny/cancel) or the caller hangs forever.
+  // Palette/mentions/copy have no such awaited caller, so they drop silently.
+  const cancelable =
+    !prior &&
+    (shell.overlayKind === "permissions" || shell.overlayKind === "operator")
+  const onCancel = cancelable ? bag?.overlayOnCancel ?? null : null
 
   shell.overlayList = null
   shell.overlayKind = null
@@ -3165,7 +3192,8 @@ export function closeInsetOverlay(shell: AppShell): void {
   shell.paletteCommands = []
   shell.copyTargets = null
   clearOverlayBody(shell)
-  // Esc / dismiss: drop accept path without invoking callbacks.
+  // Esc / dismiss: drop accept path without invoking it (onCancel above is
+  // captured before this clears, and is invoked separately once state settles).
   if (bag && !prior) {
     bag.overlayItemIds = []
     bag.overlayOnAccept = null
@@ -3174,6 +3202,7 @@ export function closeInsetOverlay(shell: AppShell): void {
     bag.overlayDescribe = null
     bag.overlayOnAction = null
     bag.overlayAnswer = null
+    bag.overlayOnCancel = null
   }
 
   // Pop exactly one frame (palette or overlay).
@@ -3202,6 +3231,7 @@ export function closeInsetOverlay(shell: AppShell): void {
     bag.overlayOnAction = prior.onAction
     bag.overlayAnswer = prior.answer
     bag.overlayTitleText = prior.titleText
+    bag.overlayOnCancel = prior.onCancel
     // If focus was not stacked (edge case), re-open overlay frame.
     if (focusOwner(shell.focus) !== "overlay") {
       shell.focus = openOverlay(shell.focus, OVERLAY_FRAME_ID, {
@@ -3230,6 +3260,7 @@ export function closeInsetOverlay(shell: AppShell): void {
   relayout(shell, { overlayMode: "closed" })
   applyFocus(shell)
   notifyOverlayClosed(shell)
+  onCancel?.()
 }
 
 /**
@@ -3436,6 +3467,9 @@ export function acceptOverlaySelection(shell: AppShell): void {
   }
   // Capture before close clears per-open state.
   const perOpen = bag?.overlayOnAccept ?? null
+  // This is a deliberate accept, not a dismiss — closeInsetOverlay must not
+  // also fire the Esc/cancel path below.
+  if (bag) bag.overlayOnCancel = null
 
   if (bag?.overlayEchoChoice !== false) {
     appendStreamRow(shell, {
@@ -5023,6 +5057,7 @@ export function createAppShell(
     overlayOnAction: null,
     overlayAnswer: null,
     overlayTitleText: "",
+    overlayOnCancel: null,
     overlayClosedListeners: new Set(),
     paletteCatalog: paletteCatalogOpt,
     paletteFilter: null,