fix(agent): surface real manage_tasks parse errors (#1084)

Invalid nested fields were reported as a missing action. Use the
arktype summary, and coerce in_progress to doing at the boundary.

Author: TheGreatAxios

src/agent/tasks.ts

@@ -7,6 +7,12 @@ import type { ToolDefinition } from "@intx/types/runtime";
 export const TaskStatusSchema = type("'todo' | 'doing' | 'done' | 'cancelled'");
 export type TaskStatus = typeof TaskStatusSchema.infer;
 
+// GLM (and other Claude-shaped) payloads send in_progress; map it at the
+// boundary so stored tasks stay on the todo/doing/done/cancelled enum.
+const TaskStatusInput = type(
+  "'todo' | 'doing' | 'done' | 'cancelled' | 'in_progress'",
+).pipe((s): TaskStatus => (s === "in_progress" ? "doing" : s));
+
 export const TaskSchema = type({
   id: "string>0",
   title: "string>0",
@@ -27,12 +33,12 @@ const ManageTasksArgsSchema = type({
   "tasks?": type({
     id: "string>0",
     title: "string>0",
-    "status?": TaskStatusSchema,
+    "status?": TaskStatusInput,
   }).array(),
   "updates?": type({
     id: "string>0",
     "title?": "string>0",
-    "status?": TaskStatusSchema,
+    "status?": TaskStatusInput,
   }).array(),
 });
 
@@ -175,10 +181,10 @@ export type ManageTasksRunner = (rawArgs: Record<string, unknown>) => Promise<{
 export function createManageTasksRunner(): ManageTasksRunner {
   let tasks: Task[] = [];
   return async (rawArgs) => {
-    const parsed = parseManageTasksArgs(rawArgs);
-    if (parsed === null) {
+    const parsed = ManageTasksArgsSchema(rawArgs);
+    if (parsed instanceof type.errors) {
       return {
-        content: "Error: manage_tasks requires action ('create' or 'update').",
+        content: `Error: manage_tasks arguments invalid: ${parsed.summary}`,
         isError: true,
       };
     }

tests/unit/agent/tasks.test.ts

@@ -3,6 +3,7 @@ import {
   applyManageTasks,
   createManageTasksRunner,
   hasActiveTasks,
+  parseManageTasksArgs,
   type Task,
 } from "../../../src/agent/tasks.js";
 
@@ -157,4 +158,45 @@ test("manage_tasks runner rejects invalid args", async () => {
   const run = createManageTasksRunner();
   const result = await run({});
   expect(result.isError).toBe(true);
+  expect(result.content).toMatch(/action/i);
+});
+
+test("manage_tasks runner names invalid status, not missing action", async () => {
+  const run = createManageTasksRunner();
+  const result = await run({
+    action: "create",
+    tasks: [{ id: "t1", title: "Inspect", status: "bogus" }],
+  });
+  expect(result.isError).toBe(true);
+  expect(result.content).toMatch(/status/i);
+  expect(result.content).not.toMatch(/requires action/i);
+});
+
+test("manage_tasks runner accepts a GLM-shaped create with in_progress", async () => {
+  const run = createManageTasksRunner();
+  const glmPayload = {
+    action: "create",
+    tasks: [
+      { id: "t1", title: "Inspect branch", status: "in_progress" },
+      { id: "t2", title: "Write failing test", status: "todo" },
+    ],
+  };
+  const result = await run(glmPayload);
+  expect(result.isError).toBeUndefined();
+  expect(result.content).toBe("Tasks updated.");
+  expect(
+    (
+      await run({
+        action: "update",
+        updates: [{ id: "t1", status: "doing" }],
+      })
+    ).content,
+  ).toBe("No change: t1 already doing.");
+  expect(parseManageTasksArgs(glmPayload)).toEqual({
+    action: "create",
+    tasks: [
+      { id: "t1", title: "Inspect branch", status: "doing" },
+      { id: "t2", title: "Write failing test", status: "todo" },
+    ],
+  });
 });