Keep oxlint plugin fixtures off the test glob

Author: TheGreatAxios

tests/unit/oxlint-no-bare-mock-module.test.ts

@@ -1,5 +1,6 @@
 import { expect, test } from "bun:test";
 import { mkdtemp, rm, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
 import { join } from "node:path";
 
 const repoRoot = join(import.meta.dirname, "../..");
@@ -34,40 +35,49 @@ function findingsForRule(stdout: string): unknown[] {
   return (parsed.diagnostics ?? []).filter((item) => item.code === ruleCode);
 }
 
-test("oxlint reports bare mock.module in a *.test.ts file", async () => {
-  const dir = await mkdtemp(
-    join(import.meta.dirname, "oxlint-mock-module-banned-"),
-  );
-  const file = join(dir, "banned.test.ts");
+// bun test ./tests collects leftover *.test.ts under tests/; keep fixtures off that glob.
+async function withFixture(
+  prefix: string,
+  name: string,
+  source: string,
+  run: (file: string) => Promise<void>,
+): Promise<void> {
+  const dir = await mkdtemp(join(tmpdir(), prefix));
+  const file = join(dir, name);
   try {
-    await writeFile(
-      file,
-      `import { mock } from "bun:test";
-mock.module("./example.js", () => ({}));
-`,
-    );
-    const { stdout, stderr } = await runOxlint(file);
-    expect(findingsForRule(stdout).length, stderr || stdout).toBeGreaterThan(0);
+    await writeFile(file, source);
+    await run(file);
   } finally {
     await rm(dir, { recursive: true, force: true });
   }
+}
+
+test("oxlint reports bare mock.module in a *.test.ts file", async () => {
+  await withFixture(
+    "oxlint-mock-module-banned-",
+    "banned.test.ts",
+    `import { mock } from "bun:test";
+mock.module("./example.js", () => ({}));
+`,
+    async (file) => {
+      const { stdout, stderr } = await runOxlint(file);
+      expect(findingsForRule(stdout).length, stderr || stdout).toBeGreaterThan(
+        0,
+      );
+    },
+  );
 });
 
 test("oxlint is clean when a *.test.ts file only uses withMockedModule", async () => {
-  const dir = await mkdtemp(
-    join(import.meta.dirname, "oxlint-mock-module-clean-"),
-  );
-  const file = join(dir, "clean.test.ts");
-  try {
-    await writeFile(
-      file,
-      `import { withMockedModule } from "../helpers/mock-module.ts";
+  await withFixture(
+    "oxlint-mock-module-clean-",
+    "clean.test.ts",
+    `import { withMockedModule } from "../helpers/mock-module.ts";
 await withMockedModule("./example.js", () => ({}));
 `,
-    );
-    const { stdout, stderr } = await runOxlint(file);
-    expect(findingsForRule(stdout), stderr || stdout).toEqual([]);
-  } finally {
-    await rm(dir, { recursive: true, force: true });
-  }
+    async (file) => {
+      const { stdout, stderr } = await runOxlint(file);
+      expect(findingsForRule(stdout), stderr || stdout).toEqual([]);
+    },
+  );
 });