Skip to content

Commit c41027a

Browse files
committed
Wire test, docs, and report conventions into builder chain
1 parent a61cd76 commit c41027a

3 files changed

Lines changed: 14 additions & 1 deletion

File tree

plugins/corbits-skills/skills/implement/SKILL.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ The order of operations depends on whether you're fixing a bug or building a fea
9292

9393
Keep the test focused on the behavior introduced by this commit. Don't test unrelated functionality. The test is part of the deliverable, not an afterthought.
9494

95+
The test lands in the same commit as the implementation (Step 4) — one logical unit (source of truth: style skill, AGENTS.md).
96+
9597
Keep the scope tight to what was discussed. If you discover additional work is needed, finish the current commit's scope first and note the additional work for a future commit.
9698

9799
### Step 3: Build Gate
@@ -105,12 +107,13 @@ Run `make` (or the project's equivalent full pipeline: format, lint, build, test
105107
- If the build fails due to pre-existing issues unrelated to your changes, report the failure to the caller and let them decide how to proceed
106108
- Do not move forward with a broken build
107109
- Do not substitute partial builds (e.g., running only the compiler) for the full pipeline
110+
- Record the exact verification commands and their exit statuses: the report maps each success criterion to pass, fail, or blocked with command evidence
108111

109112
### Step 4: Commit
110113

111114
Update `activeForm` to "Committing: {subject}".
112115

113-
Create the commit. Follow the commit message conventions from the `style` skill. Include the test in the same commit as the implementation — they are one logical unit of work.
116+
Create the commit. Follow the commit message conventions from the `style` skill. Include the test in the same commit as the implementation — they are one logical unit of work — and the docs updates when the commit changes documented behavior.
114117

115118
### Step 5: Critique Loop
116119

src/agent/directors/builder/package.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,14 @@ describe("builderPackage", () => {
167167
expect(prompt).toMatch(/Summary \/ Findings \/ Blockers \/ Paths/);
168168
});
169169

170+
test("systemPrompt wires same-commit tests, docs upkeep, and report mapping", () => {
171+
const p = builderPackage.systemPrompt;
172+
expect(p).toMatch(/same commit/);
173+
expect(p).toMatch(/docs that describe it/i);
174+
expect(p).toContain("success_criteria");
175+
expect(p).toMatch(/exit status/);
176+
});
177+
170178
test("systemPrompt preserves public API sync/async under Guidelines", () => {
171179
const prompt = builderPackage.systemPrompt;
172180
expect(prompt).toMatch(/Public API shapes/i);

src/agent/directors/builder/package.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ The order of operations depends on whether you're fixing a bug or building a fea
6060
6161
Keep the test focused on the behavior introduced by this unit of work. Don't test unrelated functionality. The test is part of the deliverable, not an afterthought.
6262
63+
Land the test in the same commit as the implementation — one logical unit. When the change alters documented behavior, update the docs that describe it in the same commit (source of truth: style skill, AGENTS.md).
64+
6365
Keep the scope tight to the brief. If you discover additional work is needed, finish the current brief's scope first and note the additional work under Blockers / Findings for a future unit.
6466
6567
## Build Gate

0 commit comments

Comments
 (0)