Skip to content

Commit c000182

Browse files
committed
Correct stale overlay docstring, duplicate import, and doc claim
1 parent 52af711 commit c000182

3 files changed

Lines changed: 8 additions & 9 deletions

File tree

docs/TUI.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,9 @@ blank row separates the subject from context. Choices are deliberately small:
325325
each one is a bare, single-line action name (`Reject`, `Accept once`, the
326326
scope's label) with no consequence text folded into the row. A scope's hint
327327
paints instead as a body message above the choice list
328-
(`permissionBodyFromRequest` in `src/tui/gate-wire.ts`), and the expand key
329-
reveals the full body — collapsed payloads and hints alike — in the overlay
328+
(`permissionBodyFromRequest` in `src/tui/gate-wire.ts`), and the expand key,
329+
which binds only when the subject carries collapsed payloads, reveals the
330+
full body — collapsed payloads and hints alike — in the overlay
330331
and, whole, in the transcript. Every choice reserves the same fixed two rows
331332
(label plus a row of air) so list paging stays a simple multiple. The active
332333
choice is marked by text color alone — cream (`UI.text`) against the dim rows

src/tui/decision-truncation.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ import { SelectRenderable } from "@opentui/core";
1010
import type { PermissionRequest } from "../permission/types.js";
1111
import { withTestRenderer } from "./harness";
1212
import { createAppShell } from "./shell/index.js";
13-
import { toggleOverlayExpand } from "./shell/overlay-list.js";
14-
import { createOverlayList } from "./shell/overlay-list";
13+
import { createOverlayList, toggleOverlayExpand } from "./shell/overlay-list.js";
1514
import { wireGates } from "./gate-wire.js";
1615
import { DECISION_CHOICE_ROWS } from "./overlay-body";
1716
import {

src/tui/overlay-list.test.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
/**
2-
* Selection continuity of the shell's overlay list across count and height
3-
* changes. Scroll clamping and windowing itself are delegated to
4-
* @opentui/core's SelectRenderable and are not re-tested here; what this pins
5-
* is the wrapper's own reshape/setCount logic that carries the live selection
6-
* across a rebuild so a resize does not snap the cursor back.
2+
* Overlay-list navigation and windowing: page/jump/move clamping, the
3+
* end-exclusive visible window, and the setCount/setHeight/reshape logic
4+
* that carries the live selection across a rebuild so a resize or list
5+
* change does not snap the cursor back.
76
*/
87
import { describe, expect, test } from "bun:test";
98
import { withTestRenderer } from "./harness";

0 commit comments

Comments
 (0)