Commit be7644b
committed
Correct the short-circuit test's comment to match what it actually guards
The comment claimed swapping the cap and scrub back would fail this
test. It does not: the secret sits at the front of a 90KB payload,
nowhere near the cap boundary, so cap-then-scrub still leaves the
whole key intact for the scrub to catch. This test guards the
PREPENDED POSITION of both terminal concerns (moving them away from
the front of the array fails it); the RELATIVE order between them is
guarded only by the boundary-straddle test. Leaving the old comment
in place risked a future engineer reading this test as redundant
coverage and deleting the straddle test, silently reopening the
exploit.1 parent 2674b74 commit be7644b
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
341 | | - | |
342 | | - | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
343 | 350 | | |
344 | 351 | | |
345 | 352 | | |
| |||
0 commit comments