Skip to content

Commit bcd01d1

Browse files
Overhaul interview skill (#660)
Rewrite the ask_operator MC interview utility: drop fake batch/option ceilings and tool-schema restatement, keep findings-only output, and pin the contract in catalog tests. Closes CL-7036
1 parent bfcc3d3 commit bcd01d1

2 files changed

Lines changed: 28 additions & 14 deletions

File tree

plugins/corbits-skills/skills/interview/SKILL.md

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ description: Conduct an iterative multiple-choice interview using ask_operator.
66

77
# Interview
88

9-
Use this skill to gather user input on a topic by asking multiple-choice questions in batches via `ask_operator`. Return the questions and answers in the conversation. The caller decides what to do with them.
9+
Gather structured user input on a topic via multiple-choice `ask_operator` questions. Emit the Q&A inline; the caller decides what to do with it.
1010

11-
This is a utility, not a planner. It does not decide what to build, write any files, or invoke other skills.
11+
This is a utility, not a planner. It does not decide what to build, write any files, spawn agents, or invoke other skills.
1212

1313
## Argument
1414

@@ -23,15 +23,17 @@ If no topic is given, ask for one with `ask_operator` before proceeding.
2323

2424
### Identify dimensions to probe
2525

26-
Enumerate the open questions worth asking, drawn from the topic and context. Skip dimensions the context already settles. Add domain-specific ones where relevant. There is no fixed dimension list — the topic determines it.
26+
Enumerate the open questions worth asking from the topic and context. Skip dimensions the context already settles. Add domain-specific ones where relevant. There is no fixed dimension list — the topic determines it.
2727

2828
Probe objective and priorities before details. They shape every later question, so anchoring them early prevents reshuffling halfway through.
2929

30-
### Ask in batches
30+
### Ask with ask_operator
3131

32-
Each question is one `ask_operator` call: `question` (string) plus `options` (array of strings). Batch a round by firing 2–4 independent `ask_operator` calls together (parallel tool calls). Refer to the tool's own documentation for parameter limits.
32+
Each question is one `ask_operator` call: `question` (string) plus `options` (array of strings). Fire independent questions together as parallel tool calls in the same turn.
3333

34-
`ask_operator` is single-select per call. The operator can also type a custom answer. There is no multi-select flag — if a dimension genuinely permits several answers, encode the realistic combinations as options, or follow up with a second question once the first answer lands.
34+
`ask_operator` is single-select per call. The operator can also type a custom answer. There is no multi-select flag — if a dimension genuinely permits several answers, encode the realistic combinations as options, or follow up once the first answer lands.
35+
36+
**No false caps.** `ask_operator` has no skill-invented ceiling on option count, parallel questions per round, or total rounds. Batch every independent dimension you can author now. Drop to one question only when the next question's text or options cannot be written without this answer. Stop when marginal value is low (see below) — never because a made-up quota was hit. If the caller passed an explicit cap, honour it.
3537

3638
**Quality bar for options:**
3739

@@ -42,11 +44,7 @@ Each question is one `ask_operator` call: `question` (string) plus `options` (ar
4244
- Combination options only when the dimension genuinely permits more than one answer
4345
- If you have a recommendation, put it first and label it
4446

45-
**Batching:**
46-
47-
- Default 2–4 `ask_operator` calls per round, bundling dimensions that do not depend on each other
48-
- Drop to 1 question only when the next question's text or options cannot be authored without this answer
49-
- Referencing a prior answer inside a later question's text is fine
47+
Referencing a prior answer inside a later question's text is fine.
5048

5149
### Decide when to stop
5250

@@ -57,7 +55,7 @@ Stop when:
5755
- The user has signalled fatigue (declines to choose, short non-substantive custom answers, asks to wrap up)
5856
- The topic has shifted into territory outside this interview's scope
5957

60-
There is no fixed round cap. Stop when the marginal value of another round is low. If the caller passed an explicit cap, honour it.
58+
There is no fixed round cap. Stop when the marginal value of another round is low.
6159

6260
### Handle trouble
6361

@@ -92,7 +90,7 @@ After emitting the findings, stop. Do not load other skills, invoke other agents
9290

9391
**Invocation:** `use_skill(name="interview")` with the topic in the conversation, or `/interview notification system; backend is Node/Postgres, internal users only, must integrate with existing auth`
9492

95-
**Round 1** (3 parallel `ask_operator` calls, bundled because none depends on the others):
93+
**Round 1** (three parallel `ask_operator` calls — independent dimensions, so ask together):
9694

9795
```
9896
ask_operator({
@@ -138,7 +136,8 @@ ask_operator({
138136
## Anti-patterns
139137

140138
- **Interviewing yourself.** Filling in answers because they "seem obvious" — stop and ask, or note as assumption.
141-
- **One question per round, ten rounds deep.** Batch related questions as parallel `ask_operator` calls.
139+
- **Serializing independent questions.** If dimensions do not depend on each other, ask them in parallel.
140+
- **Inventing quotas.** Do not stop or thin options because of a made-up question or option count.
142141
- **Asking about everything.** Prune dimensions that do not apply.
143142
- **Treating a custom answer as failure.** Custom answers are signal.
144143
- **Forgetting context.** Read it. Do not re-ask things the context already settled.

tests/unit/corbits-skills-catalog.test.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,21 @@ test("review skill routes critique/neckbeard/greybeard via task or spawn_agent/w
135135
expect(skill).not.toContain('task(agent="greybeard")');
136136
});
137137

138+
test("interview skill is an ask_operator utility with no false caps", async () => {
139+
const skill = await Bun.file(join(pluginRoot, "skills/interview/SKILL.md")).text();
140+
expect(skill).toContain("ask_operator");
141+
expect(skill).toMatch(/utility/i);
142+
expect(skill).toContain("## Interview findings:");
143+
expect(skill).toContain("No false caps");
144+
expect(skill).not.toContain(USER_INVOCABLE_FALSE);
145+
expect(skill).not.toMatch(/24/);
146+
expect(skill).not.toMatch(/at most \d+/i);
147+
expect(skill).not.toMatch(/parameter limits/i);
148+
expect(skill).not.toMatch(/maxItems|minItems|inputSchema/i);
149+
expect(skill).not.toContain("write a file");
150+
expect(skill).toContain("never writes a file");
151+
});
152+
138153
test("create-issue is Linear-first without restated MCP tool contracts", async () => {
139154
const skill = await Bun.file(join(pluginRoot, "skills/create-issue/SKILL.md")).text();
140155
expect(skill).toContain("mcp__linear__");

0 commit comments

Comments
 (0)