Skip to content

Commit 93e5fff

Browse files
committed
Restore Critic verify-by-temporary-test workflow
1 parent bf79cc0 commit 93e5fff

2 files changed

Lines changed: 28 additions & 0 deletions

File tree

src/agent/directors/critic/package.test.ts

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,23 @@ describe("criticPackage", () => {
7373
);
7474
});
7575

76+
test("systemPrompt restores verify-by-temporary-test workflow", () => {
77+
const p = criticPackage.systemPrompt;
78+
expect(p).toMatch(/Verify by temporary test/i);
79+
expect(p).toMatch(/Form hypotheses/i);
80+
expect(p).toContain("tmp/critique-tests/");
81+
expect(p).toMatch(/report only verified issues/i);
82+
expect(p).toMatch(/keepers for permanent inclusion/i);
83+
expect(p).toMatch(/clean up/i);
84+
});
85+
86+
test("systemPrompt owns no report envelope", () => {
87+
const p = criticPackage.systemPrompt;
88+
expect(p).not.toMatch(/## Summary/);
89+
expect(p).not.toMatch(/## Findings/);
90+
expect(p).not.toMatch(/Recommended Tests for Permanent Inclusion/);
91+
});
92+
7693
test("systemPrompt has no tool-schema restatement or fake caps", () => {
7794
const p = criticPackage.systemPrompt;
7895
expect(p).not.toMatch(/parameters?:/i);

src/agent/directors/critic/package.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ import { REVIEW_TOOLS } from "../tool-sets.js";
44
/**
55
* Critic worker (CL-5819 / CL-7021 / CL-7015 rename from critique).
66
* Critic identity — defects with evidence; never fix product code.
7+
* Verify-by-temporary-test workflow restored from the GaaS critique.md
8+
* original (CL-7655) — pin 6e16b6c does not resolve in the local agents
9+
* checkout, so the wording was verified against critique.md as present at
10+
* local HEAD c0efce7 (imported from alexanderguy/skills at e33fe00, last
11+
* synced at 3743b7d) rather than copied 1:1.
712
*/
813
export const criticPackage: DirectorPackage = {
914
id: "critic",
@@ -36,6 +41,12 @@ Evidence rules:
3641
- Call out gaps: what you did not cover so the parent does not assume closed.
3742
- Recommend permanent tests the suite should keep (name the scenario; do not implement them here — route to testsmith/builder).
3843
44+
Verify by temporary test — hypotheses need evidence, not vibes:
45+
- Form hypotheses first: name each suspected defect before testing it.
46+
- Write focused temp tests under 'tmp/critique-tests/' with the repo's own framework, and run them with the existing suite.
47+
- A test that disproves a hypothesis discards the finding — report only verified issues.
48+
- Recommend keepers for permanent inclusion (uncovered critical paths, edge cases, regression guards); clean up the rest — route keepers to testsmith/builder, never commit them from here.
49+
3950
Correctness and this-diff hygiene:
4051
- Flag gaps that affect correctness or the stated requirements/success_criteria.
4152
- Also flag hygiene this diff introduced: dead code, duplication, needless abstraction. Cite path. Do not fix.

0 commit comments

Comments
 (0)