Skip to content

Commit 7eba77a

Browse files
committed
Restore the refactor skill 1:1 with GaaS
Replace Corbits ask_operator phrasing with Guy's GaaS body. Slash /refactor remains. ask_operator mapping stays on native-integration. Ignore GaaS refactor SKILL.md in prettier so list alignment stays 1:1.
1 parent 6cc765b commit 7eba77a

5 files changed

Lines changed: 18 additions & 6 deletions

File tree

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ scratch/
55
node_modules/
66
CHANGELOG.md
77
plugins/corbits-skills/skills/opsh/SKILL.md
8+
plugins/corbits-skills/skills/refactor/SKILL.md
89

910
tmp/
1011
.claude/

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ parallel copies under `docs/` or `scripts/notes/`. At cut time: rename
2121

2222
- Restore the opsh skill 1:1 with GaaS. Tool/shell mapping stays on native-integration. user-invocable: false stays so it remains use_skill-only.
2323
- Restore the pull-request-review skill 1:1 with GaaS. ask_operator, /review mapping, and GitHub posting stay on native-integration. Slash /pull-request-review remains.
24-
- Ignore GaaS opsh SKILL.md in prettier so table alignment stays 1:1.
24+
- Restore the refactor skill 1:1 with GaaS. ask_operator mapping stays on native-integration. Slash /refactor remains.
25+
- Ignore GaaS opsh and refactor SKILL.md in prettier so table/list alignment stays 1:1.
2526
- Restore the git-rebase skill body 1:1 with GaaS. Intern execution recipe stays on native-integration. user-invocable: false stays so it remains use_skill-only.
2627
- Restore the linear-issue-workflow skill body 1:1 with GaaS. Claim-first, In Review, and git-worktrees extras stay on native-integration. user-invocable: false stays so it remains use_skill-only.
2728
- Restore the interview skill body 1:1 with GaaS (AskUserQuestion). Operator-ask mapping stays on native-integration. Slash /interview remains.

plugins/corbits-skills/skills/native-integration/SKILL.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ When a GaaS skill names a Claude/GaaS tool, use the Corbits equivalent. Do not c
4141

4242
Slash names that differ from GaaS skill ids: `/review` is GaaS `code-review`; `/create-issue` is GaaS `linear-create`. Keep those Corbits names.
4343

44+
GaaS refactor says "ask clarifying questions" / "ask the user". Corbits extras: `ask_operator` (tool mapping above). Do not fork the GaaS refactor body.
45+
4446
When GaaS implement says you are orchestrated by karen, that is the Corbits primary (Skywalker). Route those disposition decisions through the primary, not a worker.
4547

4648
## Linear claim-first

plugins/corbits-skills/skills/refactor/SKILL.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,14 @@ Before doing anything else, load the `philosophy` skill. The principles in that
1818

1919
The user has specified a directory to analyze: `$ARGUMENTS`
2020

21-
If the directory is broad, `ask_operator` before exploring:
22-
21+
If the directory is broad, ask clarifying questions:
2322
- Is there a specific concern or area they want to focus on?
2423
- What prompted the desire to refactor?
2524
- Are there known pain points?
2625

2726
### Step 2: Examine the Code
2827

2928
Explore the specified directory to understand:
30-
3129
- What the code does (purpose and behavior)
3230
- Key components and their responsibilities
3331
- How data flows through the system
@@ -57,7 +55,7 @@ Document structure:
5755

5856
After documenting the current state:
5957

60-
1. Present your observations and `ask_operator` about priorities
58+
1. Present your observations and ask the user about their priorities
6159
2. Propose specific improvements with rationale grounded in philosophy principles (pragmatic, simple over easy, etc.)
6260
3. Let the user accept, reject, or modify proposals
6361
4. Ask follow-up questions to refine the approach
@@ -81,7 +79,6 @@ A single markdown file in the user's current working directory containing both t
8179
## Guiding Principles
8280

8381
From the philosophy skill:
84-
8582
- **Pragmatic over idealistic** - Don't propose changes for theoretical purity
8683
- **Simple is usually harder than easy** - Favor designs that are genuinely simple, not just quick
8784
- **Do no harm** - Consider risks to stability and correctness

tests/unit/corbits-skills-catalog.test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,16 @@ test("review skill is a code-review playbook, not a director router", async () =
239239
expect(skill).not.toContain('task(agent="greybeard")');
240240
});
241241

242+
test("refactor skill is 1:1 with GaaS refactor", async () => {
243+
const skill = await Bun.file(join(pluginRoot, "skills/refactor/SKILL.md")).text();
244+
expect(skill).toContain("ask clarifying questions:");
245+
expect(skill).toContain("ask the user about their priorities");
246+
expect(skill).toContain("load the `philosophy` skill");
247+
expect(skill).not.toContain("ask_operator");
248+
expect(skill).not.toContain(USER_INVOCABLE_FALSE);
249+
expect(skill).not.toContain("## Acknowledgment");
250+
});
251+
242252
test("pull-request-review is 1:1 with GaaS pull-request-review", async () => {
243253
const skill = await Bun.file(join(pluginRoot, "skills/pull-request-review/SKILL.md")).text();
244254
expect(skill).toContain("git worktree add");
@@ -398,6 +408,7 @@ test("native-integration maps GaaS tool names and parks Corbits extras", async (
398408
expect(skill).toContain("Do not fork the GaaS git-rebase body");
399409
expect(skill).toContain("Do not fork the GaaS opsh body");
400410
expect(skill).toContain("Do not fork the GaaS pull-request-review body");
411+
expect(skill).toContain("Do not fork the GaaS refactor body");
401412
expect(skill).toContain("prove");
402413
});
403414

0 commit comments

Comments
 (0)