Pin live restore of disabled plugin commands

Disabled command plugins must already sit in the candidate list so
enablement can restore slash commands without a second register pass.

Author: TheGreatAxios

src/tui/command-catalog.ts

@@ -4,7 +4,7 @@
  * Pure: host injects `listCommands()` results (or fixtures). No registry import
  * here — avoids circular / heavy deps from `src/tui/commands`.
  *
- *   setPaletteCatalog(shell, commandItemsFromRegistry(listCommands()))
+ *   setPaletteCatalog(shell, () => commandItemsFromRegistry(listCommands()))
  */
 
 import { sliceToWidth, stringWidth } from "./view/height.js";

src/tui/commands/registry.test.ts

@@ -141,9 +141,67 @@ describe("registerCommandPlugin", () => {
     expect(getCommand("live-plugin-cmd")).toBeUndefined();
 
     active = true;
+    expect(listCommands().map((command) => command.name)).toContain("live-plugin-cmd");
     expect(getCommand("live-plugin-cmd")).toBeDefined();
   });
 
+  it("serves the next candidate when the first plugin deactivates", () => {
+    let firstActive = true;
+    registerCommandPlugin(
+      {
+        commands: [
+          {
+            name: "plugin-live-fallback",
+            description: "first",
+            handler: () => ({ type: "noop" }),
+          },
+        ],
+      },
+      () => firstActive,
+    );
+    registerCommandPlugin({
+      commands: [
+        {
+          name: "plugin-live-fallback",
+          description: "second",
+          handler: () => ({ type: "noop" }),
+        },
+      ],
+    });
+
+    expect(getCommand("plugin-live-fallback")?.description).toBe("first");
+    expect(
+      listCommands().find((command) => command.name === "plugin-live-fallback")?.description,
+    ).toBe("first");
+
+    firstActive = false;
+    expect(getCommand("plugin-live-fallback")?.description).toBe("second");
+    expect(
+      listCommands().find((command) => command.name === "plugin-live-fallback")?.description,
+    ).toBe("second");
+  });
+
+  it("does not execute a typed slash name after the plugin deactivates", () => {
+    let active = true;
+    registerCommandPlugin(
+      {
+        commands: [
+          {
+            name: "typed-after-disable",
+            description: "typed",
+            handler: () => ({ type: "message", text: "ran" }),
+          },
+        ],
+      },
+      () => active,
+    );
+
+    const stalePaletteRow = "typed-after-disable";
+    expect(getCommand(stalePaletteRow)).toBeDefined();
+    active = false;
+    expect(getCommand(stalePaletteRow)).toBeUndefined();
+  });
+
   it("lets an enabled plugin claim a name ahead of a disabled candidate", () => {
     registerCommandPlugin(
       {

tests/unit/plugin-register.test.ts

@@ -7,6 +7,7 @@ import {
   isPluginModuleEnabled,
 } from "../../src/plugins/register.js";
 import type { PluginModule } from "../../src/plugins/loader.js";
+import { getCommand } from "../../src/tui/commands/registry.js";
 
 function cmdModule(id: string, extra: Partial<PluginModule> = {}): PluginModule {
   return {
@@ -55,6 +56,17 @@ test("registerCommandPlugins registers only enabled command plugins", () => {
   expect(registered).toEqual(["reg-on"]);
 });
 
+test("registerCommandPlugins restores a disabled-at-startup command without re-registering", () => {
+  const mods = [cmdModule("reg-off-live")];
+  const config: Record<string, { enabled: boolean }> = { "reg-off-live": { enabled: false } };
+  const registered = registerCommandPlugins(mods, config);
+  expect(registered).toEqual([]);
+  expect(getCommand("reg-off-live")).toBeUndefined();
+
+  config["reg-off-live"] = { enabled: true };
+  expect(getCommand("reg-off-live")).toBeDefined();
+});
+
 test("enablePluginConfig marks enabled and preserves credentials/consented", () => {
   // Path-add must leave plugins[id].enabled === true so restart re-wires commands.
   expect(isPluginEnabled({}, "path-cmd")).toBe(false);