Fail closed when a named profile file is missing

Author: TheGreatAxios

docs/IMPLEMENTATION.md

@@ -337,7 +337,7 @@ prerequisites; Ollama installation remains outside this flow.
 Profiles supply per-project or named-profile overrides for `model` and `systemPromptExtensions` (the only allowed keys; any other key is rejected on load).
 
 - Project profile: `.corbits/profile.json` in the repo root — committed, credential-free.
-- Named profiles: `~/.corbits/profiles/<name>.json` — user-level overrides, inherited via the `profile` key or the `--profile` flag.
+- Named profiles: `~/.corbits/profiles/<name>.json` — user-level overrides, inherited via the `profile` key or the `--profile` flag. A missing named file fails closed. A missing project `profile.json` overlay is optional.
 
 ```json
 {

src/config/profiles.ts

@@ -74,15 +74,19 @@ export async function loadProfile(path: string): Promise<ProfileConfig | null> {
 export async function resolveProfile(
   cwd: string,
   profileName?: string,
+  home: string = homedir(),
 ): Promise<ProfileConfig> {
   const projectProfile = await loadProfile(projectProfilePath(cwd));
 
   const namedProfileName = profileName ?? projectProfile?.profile;
 
   let namedProfile: ProfileConfig | null = null;
   if (namedProfileName !== undefined) {
-    const namedPath = join(profilesDir(), `${namedProfileName}.json`);
+    const namedPath = join(profilesDir(home), `${namedProfileName}.json`);
     namedProfile = await loadProfile(namedPath);
+    if (namedProfile === null) {
+      throw new Error(`Profile not found: ${namedPath}`);
+    }
   }
 
   // Merge: project profile fields override named profile fields.

src/profiles.test.ts

@@ -85,6 +85,31 @@ test("resolveProfile returns empty object when no profile files exist", async ()
   expect(result).toEqual({});
 });
 
+test("resolveProfile throws when --profile names a missing file", async () => {
+  const home = makeTmp();
+  const cwd = makeTmp();
+  await mkdir(cwd, { recursive: true });
+  const name = "does-not-exist";
+  const missingPath = join(profilesDir(home), `${name}.json`);
+  expect(await loadProfile(missingPath)).toBeNull();
+  await expect(resolveProfile(cwd, name, home)).rejects.toThrow(missingPath);
+});
+
+test("resolveProfile loads a valid named profile", async () => {
+  const home = makeTmp();
+  const cwd = makeTmp();
+  await mkdir(cwd, { recursive: true });
+  const namedDir = join(home, ".corbits", "profiles");
+  await mkdir(namedDir, { recursive: true });
+  await writeFile(
+    join(namedDir, "work.json"),
+    JSON.stringify({ model: "named-model" }),
+  );
+  const result = await resolveProfile(cwd, "work", home);
+  expect(result.model).toBe("named-model");
+  expect(result.profile).toBe("work");
+});
+
 test("resolveProfile applies project profile fields", async () => {
   const cwd = makeTmp();
   const dir = join(cwd, ".corbits");
@@ -101,16 +126,20 @@ test("resolveProfile applies project profile fields", async () => {
   expect(result.systemPromptExtensions).toEqual(["ext1"]);
 });
 
-test("resolveProfile surfaces profile name when set", async () => {
+test("resolveProfile throws when a named profile key points at a missing file", async () => {
+  const home = makeTmp();
   const cwd = makeTmp();
   const dir = join(cwd, ".corbits");
   await mkdir(dir, { recursive: true });
+  const name = "no-such-named-profile";
   await writeFile(
     join(dir, "profile.json"),
-    JSON.stringify({ profile: "work" }),
+    JSON.stringify({ profile: name }),
+  );
+  const missingPath = join(profilesDir(home), `${name}.json`);
+  await expect(resolveProfile(cwd, undefined, home)).rejects.toThrow(
+    missingPath,
   );
-  const result = await resolveProfile(cwd);
-  expect(result.profile).toBe("work");
 });
 
 test("resolveProfile: project profile fields override named profile fields", async () => {