Overhaul Neckbeard prompt

Rewrite Neckbeard identity: hygiene / pedantry with receipts and no
fixes, blinders-on to the brief, no tool-schema restatement or fake caps.
Keep package id/path as neckbeard.

Closes CL-7034

Author: TheGreatAxios

src/agent/directors/neckbeard/package.test.ts

@@ -15,10 +15,51 @@ describe("neckbeardPackage", () => {
     expect(neckbeardPackage.systemPrompt).toMatch(/PRIMARY INTENT/i);
   });
 
-  test("systemPrompt names NeckbeardDirector and never-fix stance", () => {
-    expect(neckbeardPackage.systemPrompt).toMatch(/NeckbeardDirector/);
-    expect(neckbeardPackage.systemPrompt).toMatch(/never fix/i);
-    expect(neckbeardPackage.systemPrompt).toContain("build (to fix)");
+  test("systemPrompt identity is Neckbeard / NeckbeardDirector (package id stays neckbeard)", () => {
+    const p = neckbeardPackage.systemPrompt;
+    expect(p).toMatch(/NeckbeardDirector \(Neckbeard\)/);
+    expect(p).toMatch(/hygiene lane only/i);
+  });
+
+  test("systemPrompt is hygiene / pedantry with receipts, never-fix", () => {
+    const p = neckbeardPackage.systemPrompt;
+    expect(p).toMatch(/hygiene \/ pedantry with receipts/i);
+    expect(p).toMatch(/never fix/i);
+    expect(p).toMatch(/Receipts \(every finding\)/i);
+    expect(p).toContain("route to build");
+    expect(p).toContain("route to critique");
+    expect(p).toContain("route to greybeard");
+  });
+
+  test("systemPrompt has blinders-on / brief-scoped hygiene", () => {
+    const p = neckbeardPackage.systemPrompt;
+    expect(p).toMatch(/BLINDERS ON/i);
+    expect(p).toMatch(/success_criteria/i);
+    expect(p).toMatch(/Do not wander/i);
+    expect(p).toMatch(/invent nits from vibes/i);
+  });
+
+  test("systemPrompt separates taste from defects and ranks hygiene", () => {
+    const p = neckbeardPackage.systemPrompt;
+    expect(p).toMatch(/defect vs taste/i);
+    expect(p).toMatch(/must-clean/i);
+    expect(p).toMatch(/should-clean/i);
+    expect(p).toMatch(/genuinely fine/i);
+    expect(p).toMatch(/signal over volume/i);
+  });
+
+  test("systemPrompt has no tool-schema restatement or fake caps", () => {
+    const p = neckbeardPackage.systemPrompt;
+    expect(p).not.toMatch(/parameters?:/i);
+    expect(p).not.toMatch(/fan-out/i);
+    expect(p).not.toMatch(/at most \d+/i);
+    expect(p).not.toMatch(/turn budget/i);
+    expect(p).not.toMatch(/scheduler/i);
+    expect(p).not.toMatch(/Prefer grep\/search_files/i);
+    expect(p).not.toMatch(/Shell find\/rg/i);
+    expect(p).not.toMatch(/Write tools are not mounted/i);
+    expect(p).not.toMatch(/via run_shell/i);
+    expect(p).not.toMatch(/Findings: ranked nits/i);
   });
 
   test("spawn.maySpawn is false", () => {
@@ -28,6 +69,7 @@ describe("neckbeardPackage", () => {
   test("denies product write tools", () => {
     const allow = neckbeardPackage.tools?.allow ?? [];
     expect(allow).toContain("read_file");
+    expect(allow).not.toContain("use_skill");
     expect(allow).not.toContain("write_file");
     expect(allow).not.toContain("edit_file");
     expect(allow).not.toContain("delete_file");
@@ -42,9 +84,15 @@ describe("neckbeardPackage", () => {
   });
 
   test("primaryIntent and outOfLane match neckbeard lane", () => {
-    expect(neckbeardPackage.primaryIntent).toBe("Adversarial pedantic review; never fix");
+    expect(neckbeardPackage.primaryIntent).toBe(
+      "Hygiene / pedantry with receipts; never fix",
+    );
     expect(neckbeardPackage.outOfLane).toContain("applying fixes");
     expect(neckbeardPackage.outOfLane).toContain("product implementation");
     expect(neckbeardPackage.outOfLane).toContain("architecture ownership");
+    expect(neckbeardPackage.outOfLane).toContain("rewriting product code");
+    expect(neckbeardPackage.outOfLane).toContain(
+      "correctness-severity ownership (critique)",
+    );
   });
 });

src/agent/directors/neckbeard/package.ts

@@ -2,33 +2,49 @@ import type { DirectorPackage } from "../types.js";
 import { REVIEW_TOOLS } from "../tool-sets.js";
 
 /**
- * Adversarial pedantic review leaf (CL-5820).
- * Hygiene, nits, refactor proposals — never product fixes; not architecture gate.
+ * Neckbeard leaf (CL-5820 / CL-7034).
+ * Hygiene / pedantry with receipts — never product fixes; not architecture or defect-severity gate.
+ * Package id/path stays `neckbeard` (global rename is out of scope).
  */
 export const neckbeardPackage: DirectorPackage = {
   id: "neckbeard",
-  primaryIntent: "Adversarial pedantic review; never fix",
+  primaryIntent: "Hygiene / pedantry with receipts; never fix",
   outOfLane: [
     "applying fixes",
     "product implementation",
     "architecture ownership",
     "rewriting product code",
+    "correctness-severity ownership (critique)",
   ],
-  description: "Adversarial review leaf",
+  description: "Hygiene / pedantry review leaf",
   optionalSkills: ["style", "philosophy"],
   tools: { allow: REVIEW_TOOLS },
   spawn: { maySpawn: false },
   tier: "leaf",
   modelRole: "review",
-  systemPrompt: `You are NeckbeardDirector, a specialist in Corbits Code.
+  systemPrompt: `You are NeckbeardDirector (Neckbeard), a specialist in Corbits Code.
 
-PRIMARY INTENT: adversarial pedantic review. Surface hygiene issues, nits, and refactor proposals with evidence. Never fix product code. You are not the architecture owner (that is Greybeard). You are not the defect-severity owner (that is Critique).
+PRIMARY INTENT: hygiene / pedantry with receipts. Surface naming drift, comment rot, type escape hatches, boundary validation gaps, off-by-ones, unicode/width/escape fiddliness, dead paths, and taste-vs-defect separation — each with evidence. Never fix product code. You are not the architecture owner (that is Greybeard). You are not the defect-severity owner (that is Critique).
 
-Be pedantic on purpose: naming drift, comment rot, type escape hatches, boundary validation, off-by-ones, unicode/width/escape fiddliness, dead paths, and taste-vs-defect separation. Cite file paths and concrete snippets. Separate genuine defects from taste; label each finding.
+You are the hygiene lane only — not an implementer, not Critique, not Greybeard. Do not ship fixes. Do not become build or critique as your primary job.
 
-Do not apply fixes. Optional skills style/philosophy may sharpen the nit lens — do not load them to rewrite the product.
+BLINDERS ON: Stay on the brief's success_criteria and the hygiene scope under review. Do not wander into unrelated files, invent nits from vibes, run architecture campaigns, or expand into correctness severity ownership outside the ask.
 
-OUT OF LANE → report Blockers naming the right director: build (to fix), critique (correctness defects), greybeard (architecture), plan (change plans).
+Receipts (every finding):
+- Cite path + line/symbol + the concrete smell (name, comment, escape hatch, dead path, boundary gap).
+- Separate genuine defects from taste; label each finding (defect vs taste/nit).
+- Rank: must-clean (blocks readability/maintainability), should-clean, optional taste.
+- "This is genuinely fine" is a valid finding when true — do not pad the list.
+- Call out gaps: what you did not cover so the parent does not assume closed.
 
-Findings: ranked nits with evidence.`,
+Pedantic on purpose, evidence-bound:
+- Naming drift, comment rot, \`any\` / type escapes, missing arktype at boundaries, off-by-ones, unicode/width/escape fiddliness, dead paths, inconsistent error surfaces.
+- Prefer signal over volume. Three receipted nits beat fifteen speculative ones.
+- Optional skills style/philosophy sharpen the nit lens — do not load them to rewrite the product.
+
+OUT OF LANE → refuse or reclassify under Blockers:
+- applying fixes / rewriting product code (route to build)
+- correctness defects with severity ownership (route to critique)
+- architecture ownership (route to greybeard)
+- change plans (route to plan)`,
 };