Constrain guideline omit ids and validate profiles at load

Reject unknown promptSectionOmit ids in ProfileSchema via
type.enumerated over GUIDELINE_SUB_BLOCK_IDS so profile typos fail
closed at load instead of silently keeping the full guidelines.
Type omit as GuidelineSubBlockId end to end and drop the unwired
KEEPSTYLE_PROMPT_SECTION_OMIT export.

Author: TheGreatAxios

src/agent/prompts.test.ts

@@ -6,7 +6,6 @@ import {
   buildPromptDisciplineBlock,
   buildSubAgentSystemPrompt,
   GUIDELINE_SUB_BLOCK_IDS,
-  KEEPSTYLE_PROMPT_SECTION_OMIT,
 } from "./prompts.js";
 import { CORE_TOOL_NAMES, CATALOG_TOOL_NAMES } from "./tool-search.js";
 
@@ -222,27 +221,17 @@ Orchestration:
 - If context is compacted automatically, do not stop tasks early due to token fear; persist progress via manage_tasks and worker reports.`);
   });
 
-  it("keepstyle omit keeps response style, drops tool-choice / ask-vs-proceed / orchestration", () => {
-    expect([...KEEPSTYLE_PROMPT_SECTION_OMIT].sort()).toEqual([
-      "askVsProceed",
-      "orchestration",
-      "toolChoice",
-    ]);
-    const guidelines = buildGuidelines({ omit: KEEPSTYLE_PROMPT_SECTION_OMIT });
+  it("omit keeps response style, drops tool-choice / ask-vs-proceed / orchestration", () => {
+    const guidelines = buildGuidelines({
+      omit: ["toolChoice", "askVsProceed", "orchestration"],
+    });
     expect(guidelines).toContain("Response style:");
     expect(guidelines).toContain("Scope and conventions:");
     expect(guidelines).not.toContain("Tool choice:");
     expect(guidelines).not.toContain("Ask vs proceed:");
     expect(guidelines).not.toContain("Orchestration:");
   });
 
-  it("ignores unknown omit ids", () => {
-    const guidelines = buildGuidelines({ omit: ["no-such-block"] });
-    expect(guidelines).toContain("Response style:");
-    expect(guidelines).toContain("Tool choice:");
-    expect(guidelines).toContain("Orchestration:");
-  });
-
   it("threads guidelineConfig through the chat system prompt", () => {
     const full = buildChatSystemPrompt(
       undefined,
@@ -260,7 +249,7 @@ Orchestration:
       [],
       "orchestrator",
       undefined,
-      { omit: KEEPSTYLE_PROMPT_SECTION_OMIT },
+      { omit: ["toolChoice", "askVsProceed", "orchestration"] },
     );
     expect(keepstyle).toContain("Response style:");
     expect(keepstyle).not.toContain("Tool choice:");

src/agent/prompts.ts

@@ -120,22 +120,11 @@ export const GUIDELINE_SUB_BLOCK_IDS = [
 
 export type GuidelineSubBlockId = (typeof GUIDELINE_SUB_BLOCK_IDS)[number];
 
-/** Id-based guideline policy: which sub-blocks to drop. Unknown ids are ignored. */
+/** Id-based guideline policy: which sub-blocks to drop. */
 export interface GuidelineConfig {
-  readonly omit?: readonly string[];
+  readonly omit?: readonly GuidelineSubBlockId[];
 }
 
-/**
- * Omit-set for the keepstyle guideline footprint: terse response style stays,
- * tool-choice / ask-vs-proceed / orchestration guidance drops. Scope and
- * conventions (build gate, verification evidence) always stay.
- */
-export const KEEPSTYLE_PROMPT_SECTION_OMIT: readonly string[] = [
-  "toolChoice",
-  "askVsProceed",
-  "orchestration",
-];
-
 interface GuidelineBlockContext {
   readonly subAgent: boolean;
   readonly askDirector: boolean;
@@ -235,8 +224,8 @@ export function buildGuidelines(
     // Picks the collection-path copy: wait_agents vs mailbox mail.
     waitAgentsMounted?: boolean;
     // Id-based policy: drop the named sub-blocks (see GUIDELINE_SUB_BLOCKS).
-    // Unknown ids are ignored; empty (default) keeps the full guidelines.
-    omit?: readonly string[];
+    // Empty (default) keeps the full guidelines.
+    omit?: readonly GuidelineSubBlockId[];
   } = {},
 ): string {
   const ctx: GuidelineBlockContext = {

src/config/index.ts

@@ -12,6 +12,7 @@ import { COMMAND_NAME } from "../branding.js";
 
 import { isDirectorId } from "../agent/directors/registry.js";
 import { DIRECTOR_IDS, type DirectorId } from "../agent/directors/types.js";
+import type { GuidelineSubBlockId } from "../agent/prompts.js";
 import {
   validateEffort,
   type ReasoningEffort,
@@ -564,7 +565,7 @@ export interface Config {
   systemPromptExtensions?: string[];
   // Guideline sub-block ids to drop from the chat system prompt (see
   // GUIDELINE_SUB_BLOCK_IDS in agent/prompts.ts). Omitted = full guidelines.
-  promptSectionOmit?: string[];
+  promptSectionOmit?: GuidelineSubBlockId[];
   // Per-call inactivity timeout in ms (default 120_000 in the harness). Tune
   // higher for reasoning models with long silent-thinking stretches.
   inactivityTimeoutMs?: number;

src/config/profiles.ts

@@ -3,14 +3,17 @@ import { homedir } from "node:os";
 import { join } from "node:path";
 import { type } from "arktype";
 import { SETTINGS_DIR_NAME } from "../branding.js";
+import { GUIDELINE_SUB_BLOCK_IDS } from "../agent/prompts.js";
 
 const ProfileSchema = type({
   "profile?": "string",
   "model?": "string",
   "systemPromptExtensions?": "string[]",
   // Guideline sub-block ids to drop from the chat system prompt (see
   // GUIDELINE_SUB_BLOCK_IDS in agent/prompts.ts). Omitted = full guidelines.
-  "promptSectionOmit?": "string[]",
+  // Unknown ids are rejected here so profile typos fail closed at load
+  // instead of silently keeping the full guidelines.
+  "promptSectionOmit?": type.enumerated(...GUIDELINE_SUB_BLOCK_IDS).array(),
   // Per-call inactivity timeout in milliseconds. If the provider yields no
   // inference event for this many ms, the call is aborted and the user sees
   // "Request timed out". Default in the inference harness is 120_000 (2 min).

src/profiles.test.ts

@@ -57,6 +57,27 @@ test("loadProfile parses systemPromptExtensions", async () => {
   });
 });
 
+test("loadProfile parses promptSectionOmit", async () => {
+  const dir = makeTmp();
+  await mkdir(dir, { recursive: true });
+  const path = join(dir, "profile.json");
+  await writeJson(path, {
+    promptSectionOmit: ["toolChoice", "orchestration"],
+  });
+  const result = await loadProfile(path);
+  expect(result).toEqual({
+    promptSectionOmit: ["toolChoice", "orchestration"],
+  });
+});
+
+test("loadProfile rejects unknown promptSectionOmit ids", async () => {
+  const dir = makeTmp();
+  await mkdir(dir, { recursive: true });
+  const path = join(dir, "profile.json");
+  await writeJson(path, { promptSectionOmit: ["no-such-block"] });
+  await expect(loadProfile(path)).rejects.toThrow(/promptSectionOmit/);
+});
+
 test("loadProfile rejects unknown keys", async () => {
   const dir = makeTmp();
   await mkdir(dir, { recursive: true });

src/session/runtime-assembly.ts

@@ -14,6 +14,7 @@ import type {
 import type { Compactor } from "@intx/types/runtime";
 
 import { buildChatSystemPrompt } from "../agent/prompts.js";
+import type { GuidelineSubBlockId } from "../agent/prompts.js";
 import type { ToolAvailability } from "../agent/tool-search.js";
 import { gatherEnvironment } from "../agent/environment.js";
 import {
@@ -290,7 +291,7 @@ export interface SessionChatPromptArgs {
   toolAvailability: ToolAvailability;
   // Guideline sub-block ids to drop (see GUIDELINE_SUB_BLOCK_IDS).
   // Omitted = full guidelines.
-  promptSectionOmit?: readonly string[];
+  promptSectionOmit?: readonly GuidelineSubBlockId[];
   // Session-start snapshot from createAgentToolset. When provided, skip
   // rediscovery so the prompt listing and skill_search share one catalog.
   skills?: readonly SkillSummary[];