|
| 1 | +import { describe, expect, test } from "bun:test"; |
| 2 | +import { createSubAgentSessionStore } from "./session-store.js"; |
| 3 | + |
| 4 | +describe("retained session lifecycle", () => { |
| 5 | + test("a salvaged (deadline/cancel) run lands resumable even though run.ts disposed its agent", () => { |
| 6 | + const store = createSubAgentSessionStore({ maxCompleted: 5 }); |
| 7 | + const s = store.start({ description: "worker", agentId: "build", brief: "b", retained: true }); |
| 8 | + store.markRunning(s.id); |
| 9 | + // run.ts salvage path RETURNS a report (does not throw) with stopReason |
| 10 | + // "deadline", but leaves turnSucceeded=false so finally disposes the |
| 11 | + // agent. agent-fleet's .then() still routes it to complete() — passing |
| 12 | + // agentRetained:false, exactly as its real call site does whenever |
| 13 | + // result.agentRetained isn't true. |
| 14 | + store.complete(s.id, "Stopped: deadline\n\nPartial work...", { agentRetained: false }); |
| 15 | + const after = store.get(s.id); |
| 16 | + console.log("lifecycleStatus:", after?.lifecycleStatus, "retained:", after?.retained); |
| 17 | + const outcome = store.resumeOne(s.id); |
| 18 | + console.log("resumeOne outcome:", JSON.stringify(outcome)); |
| 19 | + expect(outcome.ok).toBe(false); |
| 20 | + }); |
| 21 | + |
| 22 | + test("cancelAll does not close retained completed sessions", () => { |
| 23 | + const store = createSubAgentSessionStore({ maxCompleted: 5 }); |
| 24 | + const s = store.start({ description: "worker", agentId: "build", brief: "b", retained: true }); |
| 25 | + let closed = false; |
| 26 | + store.registerClose(s.id, async () => { |
| 27 | + closed = true; |
| 28 | + }); |
| 29 | + store.complete(s.id, "done"); |
| 30 | + const cancelled = store.cancelAll("parent stop"); |
| 31 | + console.log("cancelAll returned:", cancelled, "| close invoked:", closed); |
| 32 | + expect(closed).toBe(true); |
| 33 | + }); |
| 34 | + |
| 35 | + test("retained completed sessions are exempt from the display cap without bound", () => { |
| 36 | + const store = createSubAgentSessionStore({ maxCompleted: 3 }); |
| 37 | + for (let i = 0; i < 50; i++) { |
| 38 | + const s = store.start({ description: `w${i}`, agentId: "build", brief: "b", retained: true }); |
| 39 | + store.complete(s.id, "done"); |
| 40 | + } |
| 41 | + console.log("sessions retained despite maxCompleted=3:", store.list().length); |
| 42 | + expect(store.list().length).toBeLessThanOrEqual(3); |
| 43 | + }); |
| 44 | + |
| 45 | + test("a genuinely retained clean completion IS resumable, and cancelAll releases it", () => { |
| 46 | + const store = createSubAgentSessionStore({ maxCompleted: 5 }); |
| 47 | + const s = store.start({ description: "worker", agentId: "build", brief: "b", retained: true }); |
| 48 | + store.markRunning(s.id); |
| 49 | + let closed = false; |
| 50 | + store.registerClose(s.id, async () => { |
| 51 | + closed = true; |
| 52 | + }); |
| 53 | + // Mirrors agent-fleet's real call: only a clean turnSucceeded completion |
| 54 | + // sets agentRetained. |
| 55 | + store.complete(s.id, "done", { agentRetained: true }); |
| 56 | + expect(store.resumeOne(s.id).ok).toBe(true); |
| 57 | + expect(closed).toBe(false); |
| 58 | + store.cancelAll("parent stop"); |
| 59 | + expect(closed).toBe(true); |
| 60 | + }); |
| 61 | + |
| 62 | + test("clear() releases every retained session's close handle instead of dropping it silently", () => { |
| 63 | + const store = createSubAgentSessionStore({ maxCompleted: 5 }); |
| 64 | + const s = store.start({ description: "worker", agentId: "build", brief: "b", retained: true }); |
| 65 | + store.markRunning(s.id); |
| 66 | + let closed = false; |
| 67 | + store.registerClose(s.id, async () => { |
| 68 | + closed = true; |
| 69 | + }); |
| 70 | + store.complete(s.id, "done", { agentRetained: true }); |
| 71 | + store.clear(); |
| 72 | + expect(closed).toBe(true); |
| 73 | + }); |
| 74 | + |
| 75 | + test("close_agent during the setup window waits for the handle instead of falsely reporting shutdown", async () => { |
| 76 | + const store = createSubAgentSessionStore({ maxCompleted: 5 }); |
| 77 | + const s = store.start({ description: "worker", agentId: "build", brief: "b", retained: true }); |
| 78 | + // No registerClose yet — closeOne races the agent-setup window. |
| 79 | + const closePromise = store.closeOne(s.id, 200); |
| 80 | + let registeredClose = false; |
| 81 | + setTimeout(() => { |
| 82 | + store.registerClose(s.id, async () => { |
| 83 | + registeredClose = true; |
| 84 | + }); |
| 85 | + }, 20); |
| 86 | + const status = await closePromise; |
| 87 | + expect(status).toBe("shutdown"); |
| 88 | + expect(registeredClose).toBe(true); |
| 89 | + }); |
| 90 | + |
| 91 | + test("close_agent gives up honestly (not a false shutdown) if the handle never arrives in time", async () => { |
| 92 | + const store = createSubAgentSessionStore({ maxCompleted: 5 }); |
| 93 | + const s = store.start({ description: "worker", agentId: "build", brief: "b", retained: true }); |
| 94 | + store.markRunning(s.id); |
| 95 | + const status = await store.closeOne(s.id, 30); |
| 96 | + expect(status).not.toBe("shutdown"); |
| 97 | + expect(store.get(s.id)).toBeDefined(); |
| 98 | + }); |
| 99 | +}); |
0 commit comments