From 994ac6059c52f0aa8b924e521756e72200bc5bc8 Mon Sep 17 00:00:00 2001 From: Kowser Date: Tue, 28 Jul 2026 19:45:22 -0700 Subject: [PATCH] ci: pin mcp below its 2.0.0 API rewrite for the agent-e2e mcp-testkit install mcp-testkit's own mcp[cli]>=1.0.0 bound is unbounded upward, and this Python setup installs nothing else that would cap it -- so an unpinned `pip install mcp-testkit` picks up whatever mcp is newest on the day the lane runs. mcp 2.0.0 (released 2026-07-28) is a real break, not just a rename: FastMCP moved from mcp.server.fastmcp to mcp.server.mcpserver.MCPServer, dropped the stateless_http constructor kwarg, and removed the streamable_http_app()/run() methods mcp-testkit 1.0.3's server.py calls directly. Every mcp-testkit invocation in CI (the shared instance and both suite-spawned ones) has been crashing on import since, which suite4/suite5 report as a 15s "not ready on port" timeout since the process never comes up at all. python-sdk's own agent-e2e workflow has the identical unpinned line but is accidentally shielded: it installs google-adk/openai-agents first, which pin mcp<2 themselves, so mcp-testkit's install just inherits the already-resolved 1.x mcp instead of upgrading it. This repo's Python setup is mcp-testkit-only, so it has no such accidental guard -- pin it explicitly instead. --- .github/workflows/agent-e2e.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/agent-e2e.yml b/.github/workflows/agent-e2e.yml index d0cc4ad0..5790939f 100644 --- a/.github/workflows/agent-e2e.yml +++ b/.github/workflows/agent-e2e.yml @@ -87,7 +87,11 @@ jobs: - name: Install mcp-testkit run: | python -m pip install --upgrade pip - pip install mcp-testkit + # mcp-testkit's own mcp[cli]>=1.0.0 bound is unbounded upward, and + # this Python setup is mcp-testkit-only (nothing else here caps mcp + # the way google-adk/openai-agents do for python-sdk's e2e install) + # -- so pin below mcp 2.0.0's FastMCP -> MCPServer rewrite ourselves. + pip install mcp-testkit "mcp<2.0.0" - name: Start mcp-testkit run: |