From f01a0389fc4843f6622267e5f0382916d723cb89 Mon Sep 17 00:00:00 2001 From: Aaron Jomy Date: Wed, 2 Sep 2026 10:31:10 +0200 Subject: [PATCH] [test] Correct the xfail marks tripping the nightly matrix --- test/test_crossinheritance.py | 6 ++++-- test/test_datatypes.py | 5 +++-- test/test_leakcheck.py | 7 ++++++- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/test/test_crossinheritance.py b/test/test_crossinheritance.py index 7923749..f407302 100644 --- a/test/test_crossinheritance.py +++ b/test/test_crossinheritance.py @@ -239,11 +239,13 @@ def __init__(self): assert CX.IBase4.call_get_value(c1) == 17 assert CX.IBase4.call_get_value(c2) == 27 - @mark.xfail(condition=IS_LINUX_ARM, reason="Fails with ModuleNotFoundError") def test07_templated_base(self): """Derive from a base class that is instantiated from a template""" - from cppjit.gbl.CrossInheritance import TBase1, TBase1_I, TDerived1 + import cppjit + + CX = cppjit.gbl.CrossInheritance + TBase1, TBase1_I, TDerived1 = CX.TBase1, CX.TBase1_I, CX.TDerived1 class TPyDerived1(TBase1_I): def __init__(self): diff --git a/test/test_datatypes.py b/test/test_datatypes.py index 2983d4d..f8a0f81 100644 --- a/test/test_datatypes.py +++ b/test/test_datatypes.py @@ -21,10 +21,11 @@ def setup_class(cls): cls.N = 5 # cppjit.gbl.N @mark.xfail( - condition=IS_CPP23, + condition=IS_CPP23 and not IS_MAC, reason="since C++23 (P1467) the narrowing std::complex to " "complex constructor is explicit, breaking the implicit " - "conversion of Python complex arguments", + "conversion of Python complex arguments; libc++ does not implement " + "P1467 yet, so the conversion still succeeds on macOS", ) def test01_instance_data_read_access(self): """Read access to instance public data and verify values""" diff --git a/test/test_leakcheck.py b/test/test_leakcheck.py index 6813f29..cde9bfc 100644 --- a/test/test_leakcheck.py +++ b/test/test_leakcheck.py @@ -2,7 +2,7 @@ import sys from pytest import mark, skip -from support import IS_MAC +from support import IS_MAC, IS_MAC_X86 nopsutil = False try: @@ -264,6 +264,11 @@ class Leaker { obj = ns.Leaker() self.check_func(obj, "leak_string", 2048) + @mark.xfail( + condition=IS_MAC_X86, + strict=False, + reason="RSS threshold intermittently trips on the Intel-mac runners", + ) def test08_list_creation(self): """Leak check of creating a python list from an std::list"""