404 responses are still written to the cache

[antoniostrijdom]

Bug report for Cloudinary iOS SDK

Before proceeding, please update to latest version and test if the issue persists

Describe the bug in a sentence or two.

When the cloudinary URL request fails with a 404, the downloadImageAndCacheIt function still attempts to write a 0 byte file to the cache.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)

Steps to reproduce

Simply call CLDDownloader.fetchImage(_:_:completionHandler:) with an invalid URL.

Error screenshots or Stack Trace (if applicable)

The following error is raised:

        {
        "error_code" = "-7001";
        "error_domain" = "com.cloudinary.error";
        "user_info" =         {
            NSLocalizedFailureReason = "Failed creating an image from the received data.";
        };

There was no received data.

Build/Dependency management

[x] Cocoa-Pods
[ ] Carthage
[ ] Manual import
[ ] Other (Specify)

Is the issue reproducible only on a specific device?

[x] No
[ ] Yes (specify model + iOS version)

Versions and Libraries (fill in the version numbers)

iOS Cloudinary SDK version - 2.9.0
OSX (on the dev environment) - 10.15.6 (19G73)
XCode - 12.1 (12A7403)
Swift - 5
Target iOS - 14.1

[michalkcloudinay]

Hi @antoniostrijdom, we are further investigating this issue and will update you with any new information. Thanks

[AlexPinhasov]

Hello @antoniostrijdom, is this still an issue?
We have implemented a new caching mechanism on April 2021, can you please try and update to the latest version and check back with me?