From acb451319ae906351ea92e5d95bf6bf68805f5c2 Mon Sep 17 00:00:00 2001 From: robertosuarez Date: Tue, 28 Jul 2026 10:52:00 +0200 Subject: [PATCH 1/4] Plugin: LTI Provider: Fix OIDC state cookie lost in iframe by requiring Secure with SameSite=None --- plugin/lti_provider/db/lti13_cookie.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin/lti_provider/db/lti13_cookie.php b/plugin/lti_provider/db/lti13_cookie.php index 6b5afc70091..6798e70980f 100644 --- a/plugin/lti_provider/db/lti13_cookie.php +++ b/plugin/lti_provider/db/lti13_cookie.php @@ -31,7 +31,7 @@ public function setCookie($name, $value, $exp = 3600, $options = []): self // SameSite none and secure will be required for tools to work inside iframes $sameSiteOptions = [ 'samesite' => 'None', - 'secure' => false, + 'secure' => true, 'httponly' => true, ]; From b6b9fad477b18b10f51355d08369280c64ff01ee Mon Sep 17 00:00:00 2001 From: robertosuarez Date: Tue, 28 Jul 2026 10:56:47 +0200 Subject: [PATCH 2/4] Plugin: LTI Provider: Fix tool type combo not updating when selected through the radiobuttons --- plugin/lti_provider/src/Form/FrmAdd.php | 3 --- plugin/lti_provider/src/Form/FrmEdit.php | 3 --- plugin/lti_provider/view/add.tpl | 15 +++++++++------ 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/plugin/lti_provider/src/Form/FrmAdd.php b/plugin/lti_provider/src/Form/FrmAdd.php index 8bc095c4072..b61b9110941 100644 --- a/plugin/lti_provider/src/Form/FrmAdd.php +++ b/plugin/lti_provider/src/Form/FrmAdd.php @@ -53,9 +53,6 @@ public function build(): void [ 'quiz' => $plugin->get_lang('Quizzes'), 'lp' => $plugin->get_lang('Learnpaths'), - ], - [ - 'onclick' => 'selectToolProvider(this.value)', ] ); diff --git a/plugin/lti_provider/src/Form/FrmEdit.php b/plugin/lti_provider/src/Form/FrmEdit.php index 57a583ea1b2..f458098adb6 100644 --- a/plugin/lti_provider/src/Form/FrmEdit.php +++ b/plugin/lti_provider/src/Form/FrmEdit.php @@ -53,9 +53,6 @@ public function build() [ 'quiz' => $plugin->get_lang('Quizzes'), 'lp' => $plugin->get_lang('Learnpaths'), - ], - [ - 'onclick' => 'selectToolProvider(this.value)', ] ); diff --git a/plugin/lti_provider/view/add.tpl b/plugin/lti_provider/view/add.tpl index 30c37490ba6..7d69819e975 100644 --- a/plugin/lti_provider/view/add.tpl +++ b/plugin/lti_provider/view/add.tpl @@ -4,16 +4,19 @@ From d4b8b3152b12165a1d411f3acb19af585059b842 Mon Sep 17 00:00:00 2001 From: robertosuarez Date: Tue, 28 Jul 2026 10:57:10 +0200 Subject: [PATCH 3/4] Plugin: LTI Provider: Add search/autocomplete (select2) to the quiz/learnpath selector --- plugin/lti_provider/view/add.tpl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/plugin/lti_provider/view/add.tpl b/plugin/lti_provider/view/add.tpl index 7d69819e975..6695606efde 100644 --- a/plugin/lti_provider/view/add.tpl +++ b/plugin/lti_provider/view/add.tpl @@ -5,10 +5,17 @@