From 11b55fdbbde563222af072c46bcdbfb4fdf09485 Mon Sep 17 00:00:00 2001 From: doxxx93 Date: Thu, 22 Oct 2026 08:18:39 +0900 Subject: [PATCH 1/2] Expect an error for IPv4-mapped IPv6 equality in network_ext tests --- tests/simple/testdata/network_ext.textproto | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/simple/testdata/network_ext.textproto b/tests/simple/testdata/network_ext.textproto index f582118..64e4600 100644 --- a/tests/simple/testdata/network_ext.textproto +++ b/tests/simple/testdata/network_ext.textproto @@ -183,12 +183,20 @@ section { test { name: "ipv4_equals_ipv6" expr: "ip('::ffff:c0a8:1') == ip('192.168.0.1')" - value: { bool_value: true } + eval_error: { + errors: { + message: "IPv4-mapped IPv6 address is not allowed" + } + } } test { name: "ipv4_not_equals_ipv6" expr: "ip('::ffff:c0a8:1') == ip('192.168.10.1')" - value: { bool_value: false } + eval_error: { + errors: { + message: "IPv4-mapped IPv6 address is not allowed" + } + } } } section { From 56bd1f6de0dbdb39ca90013356fe964ab440cc26 Mon Sep 17 00:00:00 2001 From: doxxx93 Date: Fri, 23 Oct 2026 05:50:08 +0900 Subject: [PATCH 2/2] Address review: rename the mapped case, test real cross-family inequality Signed-off-by: doxxx93 --- tests/simple/testdata/network_ext.textproto | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/simple/testdata/network_ext.textproto b/tests/simple/testdata/network_ext.textproto index 64e4600..8b5bbcc 100644 --- a/tests/simple/testdata/network_ext.textproto +++ b/tests/simple/testdata/network_ext.textproto @@ -181,7 +181,7 @@ section { value: { bool_value: false } } test { - name: "ipv4_equals_ipv6" + name: "invalid_ipv4_equals_ipv6" expr: "ip('::ffff:c0a8:1') == ip('192.168.0.1')" eval_error: { errors: { @@ -191,12 +191,8 @@ section { } test { name: "ipv4_not_equals_ipv6" - expr: "ip('::ffff:c0a8:1') == ip('192.168.10.1')" - eval_error: { - errors: { - message: "IPv4-mapped IPv6 address is not allowed" - } - } + expr: "ip('192.168.0.1') == ip('2001:db8::1')" + value: { bool_value: false } } } section {