From 2b35ec6ff981dde1e167094fc88832e9b53d8739 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Mon, 31 Aug 2026 16:16:13 -0700 Subject: [PATCH 1/8] revised PR template in accordance with governing doc --- .github/pull_request_template.md | 32 +++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5a42c81b..f6eeebbe 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,6 +2,10 @@ ## Related GitHub Issue(s) + + +## AI/LLM Usage + ## Additional Context for Reviewers @@ -9,7 +13,29 @@ - + + +## Submitter's Checklist +- [ ] I have reviewed and am adhering to the standards outlined in the project Governing Doc. +- [ ] The PR subject title summarizes the changes, with a proper prefix: + [FIX] for bug fixes + [FEAT] for enhancements + [DOCS] for documentation + [TST] for unit testing + [CHORE] for chores and maintenance tasks + [BRK] for breaking changes, deprecations, and removals +- [ ] I am a human (not a bot), and this PR is not AI generated. + + +## Reviewer's Checklist +- [ ] The implementation addresses the associated issue(s). +- [ ] The implementation is appropriate, maintainable, and follows ARCHITECTURE.md. +- [ ] AI disclosures are complete and usage is appropriate. +- [ ] PR subject title is appropriate. +- [ ] Relevant issue(s) are linked. +- [ ] Documentation and tests are appropriate. +- [ ] Additional reviewer is requested or not needed. +- [ ] CI tests passed or failure are acceptable. + + -## Checklist -- [ ] I passed tests locally for both code (`uv run pytest`) and documentation changes (`uv run --directory docs jb build . --builder=custom --custom-builder=doctest`) From acd3df794c2f41fc4a2de0ecf058ce2b59566334 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Mon, 31 Aug 2026 16:16:34 -0700 Subject: [PATCH 2/8] Spacing --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f6eeebbe..1c4fe43a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,20 +1,21 @@ ## Summary of Changes + ## Related GitHub Issue(s) + ## AI/LLM Usage -## Additional Context for Reviewers +## Additional Context for Reviewers - ## Submitter's Checklist - [ ] I have reviewed and am adhering to the standards outlined in the project Governing Doc. - [ ] The PR subject title summarizes the changes, with a proper prefix: @@ -26,7 +27,6 @@ [BRK] for breaking changes, deprecations, and removals - [ ] I am a human (not a bot), and this PR is not AI generated. - ## Reviewer's Checklist - [ ] The implementation addresses the associated issue(s). - [ ] The implementation is appropriate, maintainable, and follows ARCHITECTURE.md. From 0378e5e8312cadce6543f2b29345d4d05aa331e3 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Mon, 31 Aug 2026 16:21:13 -0700 Subject: [PATCH 3/8] Format --- .github/pull_request_template.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1c4fe43a..b192207f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,21 +1,22 @@ -## Summary of Changes +## Summary of Changes -## Related GitHub Issue(s) +## Related GitHub Issue(s) ## AI/LLM Usage - + -## Additional Context for Reviewers +## Additional Context for Reviewers + ## Submitter's Checklist - [ ] I have reviewed and am adhering to the standards outlined in the project Governing Doc. - [ ] The PR subject title summarizes the changes, with a proper prefix: @@ -30,9 +31,9 @@ ## Reviewer's Checklist - [ ] The implementation addresses the associated issue(s). - [ ] The implementation is appropriate, maintainable, and follows ARCHITECTURE.md. -- [ ] AI disclosures are complete and usage is appropriate. - [ ] PR subject title is appropriate. - [ ] Relevant issue(s) are linked. +- [ ] AI disclosures are complete and usage is appropriate. - [ ] Documentation and tests are appropriate. - [ ] Additional reviewer is requested or not needed. - [ ] CI tests passed or failure are acceptable. From 8c25da63f1e7c52738e6adfdc028797a50208be9 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Tue, 1 Sep 2026 14:54:24 -0700 Subject: [PATCH 4/8] Added url to governing doc --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b192207f..ead93af8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -18,7 +18,7 @@ ## Submitter's Checklist -- [ ] I have reviewed and am adhering to the standards outlined in the project Governing Doc. +- [ ] I have reviewed and am adhering to the standards outlined in the project [Governing Doc](https://github.com/casact/chainladder-python/blob/main/docs/library/governance.md). - [ ] The PR subject title summarizes the changes, with a proper prefix: [FIX] for bug fixes [FEAT] for enhancements From f4fdfc8e90dfaa38e6600e87addc9594ddde78c1 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Tue, 1 Sep 2026 14:55:45 -0700 Subject: [PATCH 5/8] Shorten the PR subject prefix list --- .github/pull_request_template.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ead93af8..89279772 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,13 +19,7 @@ ## Submitter's Checklist - [ ] I have reviewed and am adhering to the standards outlined in the project [Governing Doc](https://github.com/casact/chainladder-python/blob/main/docs/library/governance.md). -- [ ] The PR subject title summarizes the changes, with a proper prefix: - [FIX] for bug fixes - [FEAT] for enhancements - [DOCS] for documentation - [TST] for unit testing - [CHORE] for chores and maintenance tasks - [BRK] for breaking changes, deprecations, and removals +- [ ] The PR subject title summarizes the changes, with one proper prefix (`[FIX]`, `[FEAT]`, `[DOCS]`, `[TST]`, `[CHORE]`, or `[BRK]`). - [ ] I am a human (not a bot), and this PR is not AI generated. ## Reviewer's Checklist From 5ff14c738ceb88da511a4bb0ccf4cc915edd5a22 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Tue, 1 Sep 2026 14:58:56 -0700 Subject: [PATCH 6/8] Words --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 89279772..2d17c3b1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,14 +20,14 @@ ## Submitter's Checklist - [ ] I have reviewed and am adhering to the standards outlined in the project [Governing Doc](https://github.com/casact/chainladder-python/blob/main/docs/library/governance.md). - [ ] The PR subject title summarizes the changes, with one proper prefix (`[FIX]`, `[FEAT]`, `[DOCS]`, `[TST]`, `[CHORE]`, or `[BRK]`). -- [ ] I am a human (not a bot), and this PR is not AI generated. +- [ ] I am a human (not a bot), and this PR form is written by a human. ## Reviewer's Checklist - [ ] The implementation addresses the associated issue(s). - [ ] The implementation is appropriate, maintainable, and follows ARCHITECTURE.md. -- [ ] PR subject title is appropriate. +- [ ] PR subject title has the proper prefix and the subject is appropriate. - [ ] Relevant issue(s) are linked. -- [ ] AI disclosures are complete and usage is appropriate. +- [ ] AI/LLM Usage is diclosed are proper and usage is appropriate. - [ ] Documentation and tests are appropriate. - [ ] Additional reviewer is requested or not needed. - [ ] CI tests passed or failure are acceptable. From cfb1c2c83f6ad6d0b372f5fc4c55c67b9bf9c68d Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Tue, 1 Sep 2026 14:59:59 -0700 Subject: [PATCH 7/8] capitalization --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2d17c3b1..0fa3ec38 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -27,7 +27,7 @@ - [ ] The implementation is appropriate, maintainable, and follows ARCHITECTURE.md. - [ ] PR subject title has the proper prefix and the subject is appropriate. - [ ] Relevant issue(s) are linked. -- [ ] AI/LLM Usage is diclosed are proper and usage is appropriate. +- [ ] AI/LLM usage is diclosed are proper and usage is appropriate. - [ ] Documentation and tests are appropriate. - [ ] Additional reviewer is requested or not needed. - [ ] CI tests passed or failure are acceptable. From 20151056dc7379bd2544707a7b7acc86b136a816 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Tue, 1 Sep 2026 15:00:33 -0700 Subject: [PATCH 8/8] words and typo --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0fa3ec38..d65fac9b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -27,7 +27,7 @@ - [ ] The implementation is appropriate, maintainable, and follows ARCHITECTURE.md. - [ ] PR subject title has the proper prefix and the subject is appropriate. - [ ] Relevant issue(s) are linked. -- [ ] AI/LLM usage is diclosed are proper and usage is appropriate. +- [ ] AI/LLM usage is disclosed and appropriate. - [ ] Documentation and tests are appropriate. - [ ] Additional reviewer is requested or not needed. - [ ] CI tests passed or failure are acceptable.