Commit af0b68f
ci: run the cockpit shell control-plane e2e, which nothing invoked
#921 added apps/cockpit/e2e/control-plane.spec.ts — 7 Playwright tests over
the operational sidebar: the real Angular handshake without blank or
unresponsive states, operational controls reachable at four viewports, forced
colors preserving control boundaries and keyboard focus, and reduced motion
disabling loader and drawer animation.
Nothing ever ran it. The suite sits behind `nx e2e cockpit`, and the
cockpit-e2e matrix only dispatches caps derived from walking cockpit/** —
apps/cockpit is never a candidate. No other job named the target either:
grepping every workflow for `nx e2e` returns examples-chat-angular,
examples-ag-ui-angular, the cap matrix, and website. So this has been dead
coverage for its whole life.
Verified it actually passes before wiring it up — 7/7 in 24s locally. It goes
in the existing `cockpit` job rather than a new one because it is cheap, it
reuses that job's `npm ci`, the `cockpit` scope already gates the shell, and
required-pr-checks already aggregates the job — so it becomes merge-blocking
with no gate change. The playwright config already sets retries: 2 on CI.
Found while auditing the tags I removed from apps/cockpit in #939.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 5d7fc3b commit af0b68f
2 files changed
Lines changed: 41 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
235 | 252 | | |
236 | 253 | | |
237 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
376 | | - | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
377 | 379 | | |
378 | 380 | | |
379 | 381 | | |
| |||
386 | 388 | | |
387 | 389 | | |
388 | 390 | | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
389 | 412 | | |
390 | 413 | | |
391 | 414 | | |
| |||
0 commit comments