Skip to content

Commit 85268aa

Browse files
ci: tag releases when a release PR merges (#214)
The push guard from the release-on-demand change never matched. After the 1.26.0 / 2.27.0 release PRs merged, the push run skipped the release-please job (sdk-python run 43488257883) even though the merge commit modifies .release-please-manifest.json, so contains(toJSON(github.event.commits.*.modified), ...) was false and nothing was tagged until Release Please was dispatched by hand. A paths filter on the push trigger does the same job off the pushed diff, so the job-level guard keeps only the repository check. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 41fc333 commit 85268aa

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

‎.github/workflows/release-please.yml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ on:
33
push:
44
branches:
55
- main
6+
paths:
7+
- .release-please-manifest.json
68
workflow_dispatch:
79

810
permissions:
@@ -13,10 +15,7 @@ jobs:
1315
release-please:
1416
# Release PRs open only when someone runs this workflow. A push runs it only
1517
# when a release PR merges (it bumps the manifest), to tag the release.
16-
if: >-
17-
github.repository == 'browserbase/sdk-python' &&
18-
(github.event_name == 'workflow_dispatch' ||
19-
contains(toJSON(github.event.commits.*.modified), '.release-please-manifest.json'))
18+
if: github.repository == 'browserbase/sdk-python'
2019
runs-on: ubuntu-latest
2120

2221
steps:

0 commit comments

Comments
 (0)