Context:
Following the review on #28, commit a671419 added an all-builds-passed job ("All builds passed") meant to be the single stable required status check for the build matrix, instead of listing every Build DuckDB (python, arch) combination in branch protection.
However, on PR #34's merge (see screenshot), the checks that gated the merge are setup and Check PYTHON_VERSIONS against DuckDB wheels and Lambda runtimes, not All builds passed. This means the actual build matrix result (package-duckdb / Build DuckDB (...)) isn't a required gate. A broken build could still be auto-merged as long as setup passes.
Suggestion:
Update main's branch protection required status checks to require All builds passed (and optionally drop setup, which is just an intermediate job unrelated to build success).
Context:
Following the review on #28, commit a671419 added an
all-builds-passedjob ("All builds passed") meant to be the single stable required status check for the build matrix, instead of listing everyBuild DuckDB (python, arch)combination in branch protection.However, on PR #34's merge (see screenshot), the checks that gated the merge are
setupandCheck PYTHON_VERSIONS against DuckDB wheels and Lambda runtimes, notAll builds passed. This means the actual build matrix result (package-duckdb / Build DuckDB (...)) isn't a required gate. A broken build could still be auto-merged as long assetuppasses.Suggestion:
Update
main's branch protection required status checks to requireAll builds passed(and optionally dropsetup, which is just an intermediate job unrelated to build success).