Skip to content

Unecessary Virtual Service checks when validation Let's Encrypt DNS-01 Validation #276

Description

@rtgibbons

I believe the two blocks of code below aren't required. They appear to be validating the Virtual Service exists and is running, persumably to allow the HTTP-01 validation to succeed. If we are using DNS-01 there should be no reason to need these checks.

https://github.com/avinetworks/devops/blob/master/cert_mgmt/letsencrypt_mgmt_profile_with_dns.py#L243-L253
https://github.com/avinetworks/devops/blob/master/cert_mgmt/letsencrypt_mgmt_profile_with_dns.py#L325-L375

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions