diff --git a/amber/src/main/scala/org/apache/texera/web/model/websocket/request/EditingTimeCompilationRequest.scala b/amber/src/main/scala/org/apache/texera/web/model/websocket/request/EditingTimeCompilationRequest.scala deleted file mode 100644 index f7a585bb155..00000000000 --- a/amber/src/main/scala/org/apache/texera/web/model/websocket/request/EditingTimeCompilationRequest.scala +++ /dev/null @@ -1,35 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -package org.apache.texera.web.model.websocket.request - -import org.apache.texera.amber.operator.LogicalOp -import org.apache.texera.common.compiler.model.{LogicalLink, LogicalPlanPojo} - -case class EditingTimeCompilationRequest( - operators: List[LogicalOp], - links: List[LogicalLink], - opsToViewResult: List[String], - opsToReuseResult: List[String] -) extends TexeraWebSocketRequest { - - def toLogicalPlanPojo: LogicalPlanPojo = { - LogicalPlanPojo(operators, links, opsToViewResult, opsToReuseResult) - } -} diff --git a/amber/src/main/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequest.scala b/amber/src/main/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequest.scala index 1a92514ff90..a6153cad5ee 100644 --- a/amber/src/main/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequest.scala +++ b/amber/src/main/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequest.scala @@ -29,7 +29,6 @@ import org.apache.texera.web.model.websocket.request.python.{ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "type") @JsonSubTypes( Array( - new Type(value = classOf[EditingTimeCompilationRequest]), new Type(value = classOf[HeartBeatRequest]), new Type(value = classOf[ModifyLogicRequest]), new Type(value = classOf[ResultPaginationRequest]), diff --git a/amber/src/test/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequestSpec.scala b/amber/src/test/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequestSpec.scala index fc8199a0dd0..4fd67f7a24e 100644 --- a/amber/src/test/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequestSpec.scala +++ b/amber/src/test/scala/org/apache/texera/web/model/websocket/request/TexeraWebSocketRequestSpec.scala @@ -52,7 +52,7 @@ import org.scalatest.matchers.should.Matchers * 1. key is the 'type' string, it must be the same as corresponding backend class name * 2. value is the payload this request/event needs" * - * The keys of `TexeraWebsocketRequestTypeMap` there are `EditingTimeCompilationRequest`, + * The keys of `TexeraWebsocketRequestTypeMap` there are * `HeartBeatRequest`, `ModifyLogicRequest`, `ResultExportRequest`, * `ResultPaginationRequest`, `RetryRequest`, `SkipTupleRequest`, * `WorkflowExecuteRequest`, `WorkflowKillRequest`, `WorkflowPauseRequest`, @@ -77,7 +77,7 @@ class TexeraWebSocketRequestSpec extends AnyFlatSpec with Matchers { private def frame(typeId: String, fields: String): String = if (fields.isEmpty) s"""{"type":"$typeId"}""" else s"""{"type":"$typeId",$fields}""" - // A LogicalPlanPojo / EditingTimeCompilationRequest payload with all four lists empty. + // A LogicalPlanPojo payload with all four lists empty. private val emptyPlanFields = """"operators":[],"links":[],"opsToViewResult":[],"opsToReuseResult":[]""" @@ -107,7 +107,6 @@ class TexeraWebSocketRequestSpec extends AnyFlatSpec with Matchers { */ private val registeredRequests: List[(String, String, Class[_ <: TexeraWebSocketRequest])] = List( - ("EditingTimeCompilationRequest", emptyPlanFields, classOf[EditingTimeCompilationRequest]), ("HeartBeatRequest", "", classOf[HeartBeatRequest]), ("ModifyLogicRequest", s""""operator":$limitOpJson""", classOf[ModifyLogicRequest]), ( @@ -144,7 +143,6 @@ class TexeraWebSocketRequestSpec extends AnyFlatSpec with Matchers { // (web/model/http/request/result/, served by WorkflowExecutionsResource) and not a // TexeraWebSocketRequest subtype at all — see the divergence test below. private val expectedTypeIds: Set[String] = Set( - "EditingTimeCompilationRequest", "HeartBeatRequest", "ModifyLogicRequest", "ResultPaginationRequest", diff --git a/frontend/src/app/workspace/types/workflow-websocket.interface.ts b/frontend/src/app/workspace/types/workflow-websocket.interface.ts index 475a9a2734a..c89594e7a82 100644 --- a/frontend/src/app/workspace/types/workflow-websocket.interface.ts +++ b/frontend/src/app/workspace/types/workflow-websocket.interface.ts @@ -195,7 +195,6 @@ export type WorkflowStateInfo = Readonly<{ }>; export type TexeraWebsocketRequestTypeMap = { - EditingTimeCompilationRequest: LogicalPlan; HeartBeatRequest: {}; ModifyLogicRequest: ModifyOperatorLogic; ResultExportRequest: ResultExportRequest;